From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Moving and resetting attachments
Date: Fri, 02 Jun 2017 11:51:26 +0200
Message-ID: <87d1am4t0h.fsf@nicolasgoaziou.fr>
References: <ogmcua$c4l$1@blaine.gmane.org>
	<874lw05njr.fsf@ericabrahamsen.net> <ogot9c$aqj$1@blaine.gmane.org>
	<8737bi21dc.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dGjEx-0003eh-8U
	for emacs-orgmode@gnu.org; Fri, 02 Jun 2017 05:51:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dGjEw-0008PB-Bn
	for emacs-orgmode@gnu.org; Fri, 02 Jun 2017 05:51:31 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:41245)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dGjEw-0008Ng-5A
	for emacs-orgmode@gnu.org; Fri, 02 Jun 2017 05:51:30 -0400
In-Reply-To: <8737bi21dc.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Fri, 02 Jun 2017 17:19:11 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Looks like a good start! My first comment is, this should definitely be
> written as a patch to `org-attach-set-directory'. It's useful
> functionality, and fits well into the whole system -- so long as you
> give users a chance to say no, I don't see why it shouldn't be part of
> the library.

FWIW, I agree.

> Various comments:

[...]

> 3. This is a good use of `copy-directory' with the COPY-CONTENTS flag,
>    but I'd still recommend using `directory-files' and then looping over
>    all the files with a `map-y-or-n-p'. That will give users a chance to
>    selectively choose files to move. This is a matter of taste. If you
>    stick with `copy-directory', at least ask the user first.
> 4. I think you're right not to delete the directory afterwards. Best not
>    to assume too much.

What about using `rename-file' so as to move the whole directory to the
new location?

Maybe a defcustom could let the user choose between moving and copying
the attachment directory.

> 7. Personally I'd rework things so you only call `org-attach-dir' once.
>    How to handle this depends a bit on when when-let was introduced into
>    Emacs, and whether Org is okay to support it. Probably safest to use
>    when-let*. so:
>
> (when-let* ((attach-dir (org-attach-dir))
>             (target (read-directory-name "Move attachments to: ")))

We cannot use `when-let*'. Besides,

  (let ((attch-dir (org-attach-dir)))
    (when attach-dir
      (let ((target (read-directory-name "Move attachments to: ")))
        ...)))

is fine, too, or even

  (let ((attch-dir (or (org-attach-dir) (error "No attachment directory")))
        (target (read-directory-name "Move attachments to: ")))
    ...)


Regards,

-- 
Nicolas Goaziou