From: Kyle Meyer <kyle@kyleam.com>
To: dchechin92@gmail.com, emacs-orgmode@gnu.org
Cc: emacs@rickster.com
Subject: Re: S5 HTML export - org9.1.1
Date: Sat, 07 Oct 2017 14:51:05 -0400 [thread overview]
Message-ID: <87d15ypzae.fsf@kyleam.com> (raw)
In-Reply-To: <87shev6jxw.fsf@pclin.dcthindom.org>
dchechin92@gmail.com writes:
> I have evaluated the following function found in ox-html.el
> and indeed the S5 html works when this function is defined.
>
> (defun org-html-end-plain-list (type)
> "Insert the end of the HTML list depending on TYPE."
> (case type
> (`ordered "</ol>")
> (`unordered "</ul>")
> (`descriptive "</dl>")))
Yes, that's the function that was removed in 8855c23c6.
> I don't know if this function should appear accordly in
> ox-S5.el or elsewhere. As I don't use development environment
> I don't know how a patch has to be submitted.
>
> Anyway thank for your help. Hope it can be useful for the
> person who knows how to implement it and where.
I don't use ox-s5.el, but the I think the below fix should do. I'll
push it in a few days if no one objects.
-- >8 --
Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list
* contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of
org-html-end-plain-list.
The function org-html-end-plain-list was deleted in
8855c23c6 (ox-html: Plain list supports arbitrary attributes,
2017-02-13).
Reported-by: <dchechin92@gmail.com>
<https://lists.gnu.org/archive/html/emacs-orgmode/2017-10/msg00123.html>
---
contrib/lisp/ox-s5.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el
index 8f9501058..0496aae19 100644
--- a/contrib/lisp/ox-s5.el
+++ b/contrib/lisp/ox-s5.el
@@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info)
"<%s class='org-%s%s'>" tag tag
(if (org-export-get-node-property :INCREMENTAL plain-list t)
" incremental" ""))
- contents (org-html-end-plain-list type))))
+ contents
+ (format "</%s>" tag))))
(defun org-s5-inner-template (contents info)
"Return body of document string after HTML conversion.
--
2.14.2
next prev parent reply other threads:[~2017-10-07 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 14:36 S5 HTML export - org9.1.1 dchechin92
2017-10-07 15:21 ` Kyle Meyer
2017-10-07 15:45 ` dchechin92
2017-10-07 18:51 ` Kyle Meyer [this message]
2017-10-07 19:33 ` Rick Frankel
2017-10-08 8:39 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d15ypzae.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=dchechin92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=emacs@rickster.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).