From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [patch] structure snippet completions Date: Fri, 08 Dec 2017 00:49:42 +0100 Message-ID: <87d13q3xpl.fsf@gmx.us> References: <87mv2ya2ep.fsf@pank.eu> <87d13u6ws3.fsf@nicolasgoaziou.fr> <87vahl8oel.fsf@gmx.us> <878tegapfy.fsf@nicolasgoaziou.fr> <87h8t23yag.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN5vZ-0002rW-JS for emacs-orgmode@gnu.org; Thu, 07 Dec 2017 18:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN5vW-0001yI-E7 for emacs-orgmode@gnu.org; Thu, 07 Dec 2017 18:50:05 -0500 Received: from [195.159.176.226] (port=41525 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN5vW-0001ws-7A for emacs-orgmode@gnu.org; Thu, 07 Dec 2017 18:50:02 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eN5vH-0002qm-3z for emacs-orgmode@gnu.org; Fri, 08 Dec 2017 00:49:47 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Rasmus writes: > Hi, > > Nicolas Goaziou writes: > >> It looks like a typo, but the two lines above are commented. > > Indeed. Thanks. > >> Also, would it make sense to add a few tests? > > I never feel very creative about tests but I have added some. > > I have also pushed the code. " enabled by requiring org-tempo. > > Let me know about any issues. One possible "bug" that I discovered is illustrated by the following example. * foo suggested indention