From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Ensure org-get-tags includes all local tags Date: Tue, 05 Jun 2018 20:40:12 +0200 Message-ID: <87d0x56prn.fsf@nicolasgoaziou.fr> References: <878t7tm8tf.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQGsV-0004xY-Ri for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 14:40:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQGsS-0002ub-N9 for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 14:40:19 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:60497) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQGsS-0002tO-Fd for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 14:40:16 -0400 Received: from saiph (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 797376000E for ; Tue, 5 Jun 2018 20:40:14 +0200 (CEST) Received: from ngz by saiph with local (Exim 4.89) (envelope-from ) id 1fQGsO-0007MT-Ti for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 20:40:12 +0200 In-Reply-To: <878t7tm8tf.fsf@fastmail.fm> (Matt Lundin's message of "Tue, 05 Jun 2018 12:39:40 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode Hello, Matt Lundin writes: > With commit fbe56f89f75a8979e0ba48001a822518df2c66fe, the function > org-get-tags incorrectly removes uninherited tags from the list of tags > it returns, *even if* they are local tags. > > Expected behavior: org-get-tags should always return local tags, > regardless of whether they are excluded from inheritance. The variable > org-tags-exclude-from-inheritance should only apply to tags in parent > heading or to file tags. > > Actual behavior: if a local tag is in org-tags-exclude-from-inheritance, > org-get-tags will not return it. > > This causes problems with functions that call org-get-tags. For > instance, if org-fast-tag-selection-single-key is set, > org-set-tags-command delete all local tags that are in the list > org-tags-exclude-from-inheritance. > > I've attached a patch that fixes the issue. You're right. Thank you. Could you add a regression test for this and push the change? Regards, -- Nicolas Goaziou