From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-test: Run all ol tests on make test
Date: Thu, 28 Jul 2022 22:31:51 +0800 [thread overview]
Message-ID: <87czdp9ulk.fsf@localhost> (raw)
In-Reply-To: <tbrmf7$eld$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> On 27/07/2022 10:49, Ihor Radchenko wrote:
>>
>> You missed the
>>
>> (org-test-selector
>> (if org-test-selector org-test-selector "\\(org\\|ob\\)"))
>
> I have notices that cases in test-oc.el are named test-org-cite/... So I
> am considering renaming tests in test-ol.el in the same way from
> test-ol/... to test-org-link/... instead of modifying selectors. I have
> not noticed with approach to naming is recommended.
Either way is fine. Ideally, we should stick to org- prefix, as expected
from Elisp conventions. But we are already kind of breaking this
convention by having all the oc- ol-, etc files.
Best,
Ihor
next prev parent reply other threads:[~2022-07-28 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 15:27 [PATCH] org-test: Run all ol tests on make test Max Nikulin
2022-07-27 3:49 ` Ihor Radchenko
2022-07-27 15:43 ` Max Nikulin
2022-07-28 14:31 ` Ihor Radchenko [this message]
2022-07-28 15:14 ` [PATCH v2] " Max Nikulin
2022-07-29 13:06 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czdp9ulk.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).