From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0Lq6HqOD12TKfgEASxT56A (envelope-from ) for ; Sat, 12 Aug 2023 15:05:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KOOjHqOD12RKbQAAauVa8A (envelope-from ) for ; Sat, 12 Aug 2023 15:05:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99BFD3989F for ; Sat, 12 Aug 2023 15:05:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=hSs9UGlt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691845539; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pLmUqwhac8We1y20o7s0ojr6usUiOM+XtzSQA4Fuj8E=; b=EDDYaNgaNaE0omjBOBZZ51FEoeLY+YRbm105OxbM/K59KOIy4Smthy4HbUeioMslRZD5AW xjSF3UVp8aDff4mblXidXgHzGd+QhudK5X26+IkyIiW07bDCKahdOkO6Pzy3xrPHok5IFX OneVr2+jVL4Fzoa0Yumvx/wnX3c/1cZ47RIJPhvMKFyccPMs/mSeG4OX51TriruutCpQrI cqol/8yXJoF2MI82xcFMyVQN8vFaQqZAvzm7lIgbPUpNJG8ao0XLGwYiWLO4Wm6c0iseS8 dEbOLhGpaI+U2TAUwYQgttA9/G+iE75oQzsGghuKTpXDglfob5wBeP+wettT4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=hSs9UGlt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691845539; a=rsa-sha256; cv=none; b=GS0s0/OYXA55Y/HCobnhWIH7GOGLvsSI+o4v5t+4Z3bh/M0JGMbR3KU+RvqihgwNNFepWV T/S4nHOcIxlj2GTgNQCqG2G4NsyU0pC5cgmP96Al5dNfi4/849EalooT/+urIhz/bhO/nE BH3NvYOtfo1J1HbA1KG8IZTfvw2pp/fyxV84RcWPpNBOk7NgpwLZe2UC8+9rDMfZP1lnw2 OckabxrsspfipO8ekKlEzYkJr6l1xIFT4qUvuwoCz06K3uyPTIRjixW+RNUrRCLmoYcvCw JM1OqnvVU+fzxS+NANrH+fcu9HSP02iIwOdRoapJIN/uutQUhMct9uKN4rmg+g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUoIW-0000dG-IX; Sat, 12 Aug 2023 09:04:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUoIU-0000bK-JR for emacs-orgmode@gnu.org; Sat, 12 Aug 2023 09:04:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUo0z-0005Hz-10; Sat, 12 Aug 2023 08:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=pLmUqwhac8We1y20o7s0ojr6usUiOM+XtzSQA4Fuj8E=; b=hSs9UGltvHqwmPkNW4b+ tJXgR7PUNhl0HP++Wu2l2GMWYt9vHj4N10sNUOUcZAA3ATtgeZl+RZtQ+OuZO2aPiwJAsJSQwAJTB DF3t2vFE4aRu9HYHuVojOlt2t5RGGRBOUKtFzNstDu0ryrls7XdGgY2Yn5bVqJhGUe/iIbUpHuzQz 4iKzp4FQesH1Y6MKwr08CqOE4qtmgarC9oP4v54N/5L7T3oUoIvlnWnCkskBqGhTL0BQqUaToFy4b 28lwqz+vcvKZyb37ebHFUwiM7KSBfPdmgWCcB91eMlzsygYdqp5kQKOCp3Vgm9k62nyQ/nvWR36ZZ QcNhp2DtrjPKIg==; From: Bastien Guerry To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [POLL] Should we accept breaking changes to get rid of Org libraries that perform side effects when loading? In-Reply-To: <87bkfdud55.fsf@localhost> (Ihor Radchenko's message of "Fri, 11 Aug 2023 09:44:22 +0000") References: <87o7omg4ie.fsf@alphaville.usersys.redhat.com> <87pm91ngb8.fsf@localhost> <87jzz8f3re.fsf@alphaville.usersys.redhat.com> <87mt43agk6.fsf@localhost> <874jq8ohbr.fsf@localhost> <87bkfip3mo.fsf@gnu.org> <87r0odrkbp.fsf@localhost> <875y5pvf04.fsf@bzg.fr> <87bkfdud55.fsf@localhost> Date: Sat, 12 Aug 2023 14:46:40 +0200 Message-ID: <87cyzswhqn.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 99BFD3989F X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -6.98 X-Migadu-Spam-Score: -6.98 X-TUID: PU/IWoU86QhT Ihor Radchenko writes: > Yes, org-mouse modifies the behavior of certain key bindings. Not > directly, but by advising `org-open-at-point'. IIRC Emacs core libraries should not advise functions. This is something we should fix. Also, I'm not sure org-mouse.el has its place in Org's core nowadays. > It changes the very notion of that is a headline - the syntax definition > is altered. Very deeply nested headlines may become inlinetasks upon > loading org-inlinetask, touching all aspects of Org, not just editing. Same here, I'd be tempted to deny Org citizenship to inline tasks: it always felt like a nice hack for a niche use-case, but a hack anyway. If it modifies Org syntax in surprising ways, this is another argument for removing org-inlinetask.el from Org's core. Remember: this is not to say that inline tasks are forbidden, it's just a message for users that inline tasks are something not maintained by Org's core team. > And it is not clear how to fix this. We did not make inlinetasks into > standard Org syntax in the past and now it is in the weird state when we > have (featurep 'org-inlinetask) sprinkled across the code just to > accommodate for this conditional syntax. Yes, this is ugly. > Inlinetasks are too similar in syntax with headlines, so it is > impossible to make the change backwards-compatible. > >>> With the current state of affairs, it is often enough to >>> (require 'org-library) to get things work. If we get rid of all the >>> possible side effects, users will have to adapt their configurations >>> and we will thus violate "I won't force you to update your >>> configuration." >> >> Defining new functions is a desirable "side-effect" of all Elisp >> library, I don't think we should worry abou this. > > Defining new functions by itself is not a big deal. But there are parts > of Org that alter their behavior depending on whether a feature is > loaded (like org-inlinetask) or depending whether certain function > symbol is defined (babel). Similarly, loading new link types re-defines > Org syntax in all the documents, affecting editing of everything that > looks like the loaded link type (org-ctags). I feel like the stakes are not the same for features like org-mouse.el and org-inlinetask.el and for core features like Babel libs and links. For the former, a decision should be made relatively to the usefulness of the feature; for the latter, loading libs (with side-effects on the syntax) is required by the design of the core feature at hand (Babel and links). I'd focus on solving the problem with org-mouse and org-inlinetasks first. Let's make a poll for org-mouse.el then for org-inlinetasks.el ? -- Bastien Guerry