emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: Matt <matt@excalamus.com>, Org mailing list <emacs-orgmode@gnu.org>
Subject: Re: ob-shell: async support in "shell" vs "bash"
Date: Mon, 17 Jun 2024 15:36:15 +0000	[thread overview]
Message-ID: <87cyofbmz4.fsf@localhost> (raw)
In-Reply-To: <87frtczgu6.fsf@gmail.com>

Suhail Singh <suhailsingh247@gmail.com> writes:

>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=40d1352b
>
> I believe there's a bug in that commit.  Specifically, the commit
> message states:
>
> #+begin_quote
>   Propagate base `org-babel-header-args:shell'
>   to`org-babel-header-args:<shell-name>'.
> #+end_quote
>
> However, the code initializes org-babel-header-args:<shell-name> to nil,
> instead.

Thanks for the analysis!
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e666660c7

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-06-17 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  2:33 ob-shell: async support in "shell" vs "bash" Suhail Singh
2024-06-16 18:32 ` Matt
2024-06-16 22:02   ` Suhail Singh
2024-06-17 15:36     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyofbmz4.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=matt@excalamus.com \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).