emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: Julien Danjou <julien@danjou.info>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [PATCH 1/4] Rename org-agenda-today to org-today.
Date: Wed, 01 Dec 2010 08:26:04 -0500	[thread overview]
Message-ID: <87bp55d3pv.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <87aakrp4dr.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Tue, 30 Nov 2010 10:06:24 +0100")

Julien Danjou <julien@danjou.info> writes:

> On Tue, Nov 30 2010, Carsten Dominik wrote:
>
>> the purpose of this change is .... to be able to use
>> this also in org.el without having to load org-agenda.el?
>
> Yes, and to be consistent. The variable org-extend-today-until is
> defined in org.el, it seems more general than org-agenda, i.e. it has no
> sense to be defined as an agenda function.

Hi Julien,

These details should be in the commit message text when you post patches
to the list.  My initial reaction to your patches was 'Why do we need
this?'

Please add enough detail in the commit message text in the future so the
purpose of the patch is clearly stated.

Thanks,
Bernt

  parent reply	other threads:[~2010-12-01 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29 14:18 [PATCH 1/4] Rename org-agenda-today to org-today Julien Danjou
2010-11-29 14:18 ` [PATCH 2/4] org-habit: Use org-today Julien Danjou
2010-11-30 23:49   ` [Accepted] [Orgmode,2/4] " Carsten Dominik
2010-11-29 14:18 ` [PATCH 3/4] org-capture: use org-today Julien Danjou
2010-11-30 23:50   ` [Accepted] [Orgmode,3/4] " Carsten Dominik
2010-11-29 14:18 ` [PATCH 4/4] org: use org-today in habits auto repeat Julien Danjou
2010-11-30 23:49   ` [Accepted] [Orgmode, " Carsten Dominik
2010-11-30  6:27 ` [PATCH 1/4] Rename org-agenda-today to org-today Carsten Dominik
2010-11-30  9:06   ` Julien Danjou
2010-11-30 23:50     ` Carsten Dominik
2010-12-01 13:26     ` Bernt Hansen [this message]
2010-11-30 23:48 ` [Accepted] [Orgmode, " Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bp55d3pv.fsf@gollum.intra.norang.ca \
    --to=bernt@norang.ca \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=julien@danjou.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).