emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Stefan Vollmar <vollmar@nf.mpg.de>
Cc: Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [ox-html] bug in documentation of org-html-table-row-tags
Date: Sun, 07 Apr 2013 23:23:38 +0200	[thread overview]
Message-ID: <87bo9q2fvp.fsf@bzg.ath.cx> (raw)
In-Reply-To: <E10B9CFB-8E9E-4D20-969E-25B25E14883C@nf.mpg.de> (Stefan Vollmar's message of "Wed, 27 Mar 2013 10:35:00 +0100")

Hi Stefan,

Stefan Vollmar <vollmar@nf.mpg.de> writes:

> according to the documentation of org-html-table-row-tags in
> ox-html.el the following code can be used to assign different CSS
> classes to alternating rows:

Obviously, this option has been simply copied from org-html.el 
and the docstring was obsolete, because `head' is not dynamically
bound anymore.

> However, I would suggest to implement this differently: have an
> option "org-html-alternating-table-row-classes" (or similar) that -
> if not nil - is used for alternating class names. Or - in keeping
> with hardwired class names like "org-ul" - always use "org-row-odd"
> and "org-row-even" if "org-html-alternating-table-row-classes" is
> not nil. Users who would prefer different class names could then
> still come up with their own definition of org-html-table-row-tags
> if needed.

I pushed a fix which preserves the spirit of the previous option,
but with more variables to check against.  I know this is not the
most user-friendly we can do here, but at least it is consistent
with what the code allows.

Thanks for reporting this!

-- 
 Bastien

  reply	other threads:[~2013-04-07 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  9:35 [ox-html] bug in documentation of org-html-table-row-tags Stefan Vollmar
2013-04-07 21:23 ` Bastien [this message]
2013-04-09 10:52   ` Stefan Vollmar
2013-04-09 11:46     ` Bastien
2013-04-09 11:56       ` Stefan Vollmar
2013-04-09 14:56       ` Nicolas Goaziou
2013-04-09 15:19         ` Bastien
2013-04-09 17:18         ` Achim Gratz
2013-04-09 20:50           ` Nicolas Goaziou
2013-04-10 16:32             ` Achim Gratz
2013-04-10 17:04               ` Nicolas Goaziou
2013-04-09 17:29         ` Stefan Vollmar
2013-04-09 17:40           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo9q2fvp.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=vollmar@nf.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).