From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Changes to contrib Date: Sun, 08 Nov 2015 14:49:20 +0100 Message-ID: <87bnb4y527.fsf@gmx.us> References: <87vb9cdauy.fsf@andromedae.feelingofgreen.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvQLi-0006l5-NF for emacs-orgmode@gnu.org; Sun, 08 Nov 2015 08:49:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvQLe-0000Sk-MV for emacs-orgmode@gnu.org; Sun, 08 Nov 2015 08:49:38 -0500 Received: from plane.gmane.org ([80.91.229.3]:33879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvQLe-0000SZ-GM for emacs-orgmode@gnu.org; Sun, 08 Nov 2015 08:49:34 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZvQLc-0006pv-5y for emacs-orgmode@gnu.org; Sun, 08 Nov 2015 14:49:32 +0100 Received: from 62.80.108.8 ([62.80.108.8]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Nov 2015 14:49:32 +0100 Received: from rasmus by 62.80.108.8 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Nov 2015 14:49:32 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, Kosyrev Serge <_deepfire@feelingofgreen.ru> writes: > I have tried to use ox-taskjuggler and faced what appeared to be a > mountain of.. infelicities and semi-broken functionality. > > A need shapes the man, so I plowed through the most direct obstacles, > and finally managed to get what I want from the beast -- mostly by > adding direct Org-property -> TJ-attribute export pathways. > > I don't know what is the proper way to submit patches for the contrib/ > directory, so I made a branch on github: > > https://github.com/deepfire/org-mode/commits/ox-taskjuggler-fixes > > Please, do tell how you would like to proceed from there. Please see http://orgmode.org/worg/org-contribute.html TL;DR: git format-patch. Do you have signed FSF papers? I don't know if there's any desire to move ox-taskjuggler.el to core, nor whether it would be possible (since I don’t know if "tj" and Baptiste have signed FSF papers). > (One immediate nitpick, of course, is that none of the additions > are documented..) Some quick comments from skimming your code (note, I have no idea what a taskjuggler is): I don’t know what you refer to explicitly. But that should be fixed, I guess. I think you add some more taskjuggle keywords/properties for example. Also, you introduce a dependency on subr-x, which may or may not be an issue since it’s in contrib. org-export-map-special-nodes and org-element-multivalued-property are not proper names, as they will supposedly only be used in ox-taskjuggler. Rasmus -- Don't panic!!!