emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Olli P <kotkis@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-clock-remove-empty-clock-drawer eats LOGBOOK drawer before todo state gets logged [8.3.2 (8.3.2-52-g6d0af5-elpaplus @ /Users/Olli/.emacs.d/elpa/org-20151228/)]
Date: Wed, 06 Jan 2016 15:52:30 +0100	[thread overview]
Message-ID: <87bn8yu5e9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2ziwmzlun.fsf@gmail.com> (Olli P.'s message of "Sun, 03 Jan 2016 23:09:04 +0700")

Hello,

Olli P <kotkis@gmail.com> writes:

> Steps to reproduce:
>
> Launching Emacs with -Q, calling `M-x package-initialize` and then `M-x
> org-mode`, and evaluating the following settings:
>
> (setq org-clock-into-drawer t)
> (setq org-log-into-drawer t)
> (setq org-clock-into-drawer t)
> (setq org-log-done 'time)
> (setq org-clock-out-when-done t)
> (setq org-clock-out-remove-zero-time-clocks t)
> (setq org-todo-keywords '((sequence "TODO(t)" "WAIT(w@/!)" "|" "DONE(d!)" "CANCELED(c@)")))
>
> Creating a new task, clock-in in and immediately completing the task
> will result in:
> ----------------------------------------------------------------------
>
> * DONE I bug out
>   CLOSED: [2016-01-03 Sun 21:36]
>   - State "DONE"       from "TODO"       [2016-01-03 Sun 21:36]
>
> ----------------------------------------------------------------------
> Instead of the expected:
> ----------------------------------------------------------------------
>
>     * DONE I bug out
>       CLOSED: [2016-01-03 Sun 21:38]
>       :LOGBOOK:
>       - State "DONE"       from "TODO"       [2016-01-03 Sun 21:38]
>       :END:
>
> ----------------------------------------------------------------------
> If I wait for the timer to run for a minute then things work as expected
> as well:
> ----------------------------------------------------------------------
>
>     * DONE I bug out
>       CLOSED: [2016-01-03 Sun 23:00]
>       :LOGBOOK:
>       - State "DONE"       from "TODO"       [2016-01-03 Sun 23:00]
>       CLOCK: [2016-01-03 Sun 22:59]--[2016-01-03 Sun 23:00] =>  0:01
>       :END:
>
> ----------------------------------------------------------------------
> The culprit is `org-clock-remove-empty-clock-drawer` that gets run at
> the end of `org-clock-out` for being a `org-clock-out-hook`.

Fixed in development version. Thank you for the report.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-01-06 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-03 16:09 Bug: org-clock-remove-empty-clock-drawer eats LOGBOOK drawer before todo state gets logged [8.3.2 (8.3.2-52-g6d0af5-elpaplus @ /Users/Olli/.emacs.d/elpa/org-20151228/)] Olli P
2016-01-06 14:52 ` Nicolas Goaziou [this message]
2016-01-06 17:02   ` Olli Piepponen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bn8yu5e9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kotkis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).