From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: About org-sort -> org-sort-list with custom sort function Date: Sun, 07 May 2017 12:00:46 +0200 Message-ID: <87bmr57zqp.fsf@nicolasgoaziou.fr> References: <87inlhhgvf.fsf@gmail.com> <87vapd5qb0.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7Izk-0003XS-NQ for emacs-orgmode@gnu.org; Sun, 07 May 2017 06:00:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7Izj-0004MA-Qe for emacs-orgmode@gnu.org; Sun, 07 May 2017 06:00:52 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:33773) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d7Izj-0004LQ-Km for emacs-orgmode@gnu.org; Sun, 07 May 2017 06:00:51 -0400 In-Reply-To: <87vapd5qb0.fsf@kyleam.com> (Kyle Meyer's message of "Sat, 06 May 2017 22:55:15 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: Zhitao Gong , emacs-orgmode@gnu.org Hello, Kyle Meyer writes: > I'm a bit confused about why org-call-with-arg is necessary because I > think call-interactively already propagates the current prefix argument, > but perhaps I'm missing some subtlety here. Either way ... I thought the same. I think we can replace `org-call-with-arg' with `call-interactively' in master. >> The problem is that if you choose ?f (sorting with custom key function), >> then org-sort-list expects another argument, the compare-func, which is >> not passed to it. >> >> IMHO, there are two ways to solve this >> >> 1. Ask for the compare-func in org-sort-list, as it does for the >> getkey-func. A default value could be provided for compare-func, >> e.g., string<, <, etc. Or >> 2. Restrict the return type to a string (or integer) so that we could >> fix the compare-func I'd rather have 1. Actually, there's some confusion in `org-sort-list' about how getkey-func and compare-func are handled. For example, the question asked to bind GETKEY-FUNC is "Sort using function: ", which should really be asked for COMPARE-FUNC. IOW, we need to move this question to COMPARE-FUNC and ask a new one for GETKEY-FUNC. > And I think it's OK to not expose compare-func to the interactive > caller. In cases where sort-subr's default behavior won't do and a user > wants to supply a value for compare-func, they can create their own > command that wraps a non-interactive org-sort-list call. I disagree. getkey-func and compare-func work hand in hand. You cannot let users provide one but not the other without crippling functionality. Regards, -- Nicolas Goaziou