From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH v2] org-sort: Read compare-func in interactive calls
Date: Sun, 14 May 2017 16:54:45 -0400
Message-ID: <87bmqvqhuy.fsf@kyleam.com>
References: <871srz5mbr.fsf@kyleam.com> <20170509194750.8974-1-kyle@kyleam.com>
	<87tw4r12ww.fsf@nicolasgoaziou.fr> <8737cax2tm.fsf@kyleam.com>
	<87h90q1rf6.fsf@nicolasgoaziou.fr> <87lgq0retg.fsf@kyleam.com>
	<87shk7zw08.fsf@nicolasgoaziou.fr> <87fug7r1qz.fsf@kyleam.com>
	<878tlzz8js.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dA0XU-0005qd-Oa
	for emacs-orgmode@gnu.org; Sun, 14 May 2017 16:54:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dA0XR-0000cn-Mr
	for emacs-orgmode@gnu.org; Sun, 14 May 2017 16:54:52 -0400
Received: from pb-smtp2.pobox.com ([64.147.108.71]:61413
	helo=sasl.smtp.pobox.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1dA0XR-0000YF-H8
	for emacs-orgmode@gnu.org; Sun, 14 May 2017 16:54:49 -0400
In-Reply-To: <878tlzz8js.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Kyle Meyer <kyle@kyleam.com> writes:

[...]

>> Using an additional argument whose only purpose is to serve as a
>> interactive flag, which is what called-interactively-p's docstring
>> suggests, avoids these issues.
>
> I'd rather avoid this. What about using
>
>   (not (or executing-kbd-macro noninteractive))
>
> then, and not touch to signature?

I'm confused why called-interactively-p's docstring suggests that form.
At any rate, it won't do here:

    (funcall (lambda ()
               (interactive)
               (not (or executing-kbd-macro noninteractive))))
    =E2=87=92 t

    (call-interactively (lambda ()
                          (interactive)
                          (not (or executing-kbd-macro noninteractive))))
    =E2=87=92 t

--=20
Kyle