From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] org-agenda tag completion works with ido Date: Thu, 13 Jul 2017 00:35:57 -0400 Message-ID: <87bmopdkcy.fsf@kyleam.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVVrH-0007Lx-Pr for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 00:36:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVVrD-0004l5-0K for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 00:36:11 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:54464 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVVrC-0004fd-Ns for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 00:36:06 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nathaniel Flath , org-mode List Nathaniel Flath writes: > After upgrading to the latest org-mode, tag completion when filtering > in the agenda was broken - I had to fully enter the tag, despite using > ido (eg I would have a tag 'home', and 'ho-enter' would not compete). [...] > * org-agenda.el (org-agenda-filter-by-tag): > (org-agenda-filter-by-tag): pass t to require-match argument of completing-read. ^ repeated function name > This causes ido-mode to complete tags properly when inputting partial matches, rather > that just sending the typed input. Wouldn't this mean that, in general, ido won't complete partial matches properly when require-match is nil? That doesn't sound right. I'm not an ido user, but testing with (require 'ido-ubiquitous) (ido-ubiquitous-mode 1) partial completion seems to work fine when I hit tab after calling org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you using some other package to get ido completion for non-file/buffer completion? In this particular case, your change looks OK because I think all useful values should be in the collection. But I don't understand why you're not able to do partial completion without this change. Are you running into the same issue everywhere else that completing-read is called with a nil value for require-match? -- Kyle