emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Adam Porter <adam@alphapapa.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add option to automatically align tags in agenda view
Date: Mon, 07 Aug 2017 13:32:39 -0400	[thread overview]
Message-ID: <87bmnrthag.fsf@kyleam.com> (raw)
In-Reply-To: <87poc7o50r.fsf@alphapapa.net>

Adam Porter <adam@alphapapa.net> writes:

[...]

> +	(org-agenda-tags-column (pcase org-agenda-tags-column
> +				  ('auto (- (window-text-width)))

I believe that `auto is needed instead of 'auto because the latter will
fail with Emacs versions earlier than Emacs 25.  Though ...

> +				  (otherwise org-agenda-tags-column)))

... with just one case and a fallthrough, I'd prefer you test with eq
rather than using pcase.

-- 
Kyle

  reply	other threads:[~2017-08-07 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 13:56 [PATCH] Add option to automatically align tags in agenda view Adam Porter
2017-08-07 17:32 ` Kyle Meyer [this message]
2017-08-07 18:57   ` Adam Porter
2017-08-07 22:04     ` Kyle Meyer
2017-08-08 15:52       ` Adam Porter
2017-08-08 18:19         ` Kyle Meyer
2017-08-08 18:23           ` Kyle Meyer
2017-08-08 18:42           ` Adam Porter
2017-08-08 19:26             ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmnrthag.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).