From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WHbxOjXXwmJxTwAAbAwnHQ (envelope-from ) for ; Mon, 04 Jul 2022 14:04:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UEjrOjXXwmKD8AAA9RJhRA (envelope-from ) for ; Mon, 04 Jul 2022 14:04:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB78D3F2C5 for ; Mon, 4 Jul 2022 14:04:05 +0200 (CEST) Received: from localhost ([::1]:46402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Ko8-0002KN-QE for larch@yhetil.org; Mon, 04 Jul 2022 08:04:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Kma-0002IJ-Co for emacs-orgmode@gnu.org; Mon, 04 Jul 2022 08:02:28 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:42707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8KmV-0005Db-2j for emacs-orgmode@gnu.org; Mon, 04 Jul 2022 08:02:28 -0400 Received: by mail-pj1-x1036.google.com with SMTP id i8-20020a17090a4b8800b001ef8a65bfbdso1826441pjh.1 for ; Mon, 04 Jul 2022 05:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=bCuS87GV+uBlpB8Hm7s76ZFURkUScCbasNoTrQDUmiw=; b=U5qwxHnIWNv8IoLEv1v60wkgR6Hpw+P4YERcpy5Huy0Kvlx/0Z9ax6fPuoBnMYqt6c dATxV9Ug/7dm7Q7cgdsSE3qe+VfioEbFc7Uf34lGe0X3R/Q2Yya2FmcQWW9C+BF7Np+r YOB9/kZluG91LfOOKaJQogjvuJoAZnIZr25OLjl0E+fDmnJT9wC2NlA0xvBOadkmrYk/ MgbUzVSqsWltjB8qyeam6lhjtuhLNyXq8MeqDuDmtaPfF6phpZReDGTMEivtJQkGcwbw W6pxWHkj8B6c/XxvfMy47pXoMmkCWzSigDnq6azTMOBb/BiyTDXEgOxaUGDZMuiWyc+m 77Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=bCuS87GV+uBlpB8Hm7s76ZFURkUScCbasNoTrQDUmiw=; b=ugW3Xc80ucAsigE1lN2Mie48XdU39wRFkGpSmfosHau/HcNef6ZeShiYRc2mrTgjkf H7NQ1zLipI2iW8nV0CZVdSyjJjAZux7ev0AIyXbEoS9OglFwDcPD01ayRxzHlgpHcxa7 qdbOuhIvV+L1QVqaxFnPl9EwV5JwXENIb/pfoAywcDOY7pUJBvae9lamw68WhCCY7udx fx8XBFKTks1BXMQzLcBdPrvu9A6jPI8doptqdad7cKaF+cJy6JgsFEjBf2yWSOeuAJpr jakAah3RIHVETdnXjmmhLlEgYoIeVycHHyoE981sqLfhYp36pHtbL1cMKFjxlkDXH+Oe GltQ== X-Gm-Message-State: AJIora9i7RkXJ42OWUGLWkE763arfSKqFxeITOPwa3QG5kbrInka4C1s Fx7ORql71RmLSjmlPN8lS4ftd2iZmYM= X-Google-Smtp-Source: AGRyM1tOP7y9a1mS6N7yQVoaGi2WVEqWyiuFm+JhU6jDfJAV+xsQczq7dzXBfM02FsbrPbILKQZ5cg== X-Received: by 2002:a17:902:ce05:b0:16b:e725:6f6c with SMTP id k5-20020a170902ce0500b0016be7256f6cmr2973911plg.110.1656936141139; Mon, 04 Jul 2022 05:02:21 -0700 (PDT) Received: from localhost ([104.223.86.8]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b0016bdd80a31bsm3036480plh.218.2022.07.04.05.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 05:02:20 -0700 (PDT) From: Ihor Radchenko To: Bhavin Gandhi Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-auto-repeat-maybe: error =?utf-8?Q?=22Can=E2=80=99t?= expand minibuffer to full frame" and missing log note In-Reply-To: References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net> <87y1xdk2a7.fsf@localhost> Date: Mon, 04 Jul 2022 20:03:29 +0800 Message-ID: <87bku5nkz2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656936245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bCuS87GV+uBlpB8Hm7s76ZFURkUScCbasNoTrQDUmiw=; b=tDwbrYJntSyB39rPVEqiESy1VRqdcedl6xrhXfKGR4bYhXc0qEBgdA88r78WP7glERcVhT Nr+pKi7MiMQezBH95MYSGdZ9gmhSR9K0DhmoP5zuxQCwuA3Ef4Spj5sBCMjGrAJthWnO7X 9MZjavN9+fvLiaBu57/ZQqiwxfmcaO23RPWjl+kdTeqHpGzKvj1Qyo/G/Rd5OTYXFlJR1R xyB166AyS9HDTtiPR7SzchKocpo2mAIifjFk7SlHu9cytH/QIfREuLup/kPkaO9GOM1lG0 rJsjMfSHjXhkGboPJBY0eXx6PnMSSyf26cREme2XnyJBsQsLyODENbELzQ5tzw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656936245; a=rsa-sha256; cv=none; b=XtBr+u0ZKm+A96DO4qfiNauZIfuWJzFtaaChmL3pn6h/2aREiP3FUX2QunZzMwJBYbn53h +lcV0T+IICM6YnalBu7yZJWAJlPkOakuyAnW8fHO8IVmdxOlQfnw3+ogEMs3Cb7sJgKK44 pqhNnM2diyY1mBtpPe00WP0U73GrHQdUPVvTINOiS23up7MvH0JDfeB5SToch9YrEDX03o 4k/+JGo7LKZKyK36MAXaqAYogkglYl6V3Kawv8w3d9FXGc/w2WneE0tyYfg3MW7ixElWmP I15ddV4/axlZEh656yvSxxJsTSBo1Pjd8MQQIrXKrRijZKVoob3RUh438Wvt9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U5qwxHnI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.94 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U5qwxHnI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AB78D3F2C5 X-Spam-Score: -1.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: bnTXwjFPHoCZ Bhavin Gandhi writes: > While looking at the *Messages* buffer, I came across the command > y-or-n-p-insert-y. There are commands for n, and other keys. When we > press y, M-p etc, these commands get executed. So, even if we manage to > fix the initial example in Emacs, the hook will still run while one is > in the minibuffer. This explains the observed behavior. A possible fix could be let-binding post-command-hook to (delq #'org-add-log-note post-command-hook), though we may get a similar issue in other context in future. A better fix may relate to the fact that org-add-log-setup is usually used to run org-add-log-note at the end of current command. y-or-n-p or any other kind of command (e.g. added via advice) will break this assumption we use. So, org-add-log-setup could also store `this-command', say, in `org-log-note-this-command' and `org-add-log-note' can then execute only when `this-command' is the same with `org-log-note-this-command'. WDYT? Best, Ihor