From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2FxVEfWYsmONSAAAbAwnHQ (envelope-from ) for ; Mon, 02 Jan 2023 09:42:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +M5PEfWYsmPU1wAA9RJhRA (envelope-from ) for ; Mon, 02 Jan 2023 09:42:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 183DF1935B for ; Mon, 2 Jan 2023 09:42:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCGON-0003eP-VA; Mon, 02 Jan 2023 03:42:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCGOH-0003dt-QX for emacs-orgmode@gnu.org; Mon, 02 Jan 2023 03:41:54 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCGOF-0006wn-9h for emacs-orgmode@gnu.org; Mon, 02 Jan 2023 03:41:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EAD1524025D for ; Mon, 2 Jan 2023 09:41:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672648908; bh=qkf6kx/vBbEH0JM8Hy8YZDDqGLd9449DJGJEfJndJuk=; h=From:To:Cc:Subject:Date:From; b=Bp5rJzQBnIHrdWa3mJapwZo0pPhtq3qOycFDc+zbJ8hj9ZM8Gimpq0G5ZQY3XHvL5 eN+xaeODXSm19mEGRa3DRxo2ALjfNcXg4B3laS+2JESTY5NIdueV5MmtgjM33OF74N YIHLiEjPw/XGLMbF5qtJ5IOAKIoTaPkFbd1RqQoXQ3TE8xx+Fu8vnWarKyV8Tjm7cp Y6MHbk5YPS9+IfQ33DyWgQ6sW4EBioQzONdGDEQ4Yui11LND4xTuvu6s4AS2VfgupT 6L9Z8gXgN0USQT+jG8in1sNapkCuKPCOEkgWMG5u5Yq+8MKMl0guwz6mJzwIXlNbKr /ryuBFoy8GxNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nlq9713cGz6tpJ; Mon, 2 Jan 2023 09:41:47 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87358ywn5g.fsf@localhost> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> Date: Mon, 02 Jan 2023 08:42:17 +0000 Message-ID: <87bknh5nva.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672648949; a=rsa-sha256; cv=none; b=hpn7R8PSvR2+ko0EkXnA1vXfQf8qkE19QgofiyuLwr1IoMJFEgy9fQtT+P/BRpWbHVxv9k 57gpeoKlyCrF/zpakM30T0JrEPVueFVB6hXl5zdR4ihtdU0Q2sxiYx6d4vZyQFsP+ZevC+ 2TQBeU/CuvCuwu97PVlzZxtUqmHhIVSrZiOJBWiEgI7rKP4Jj9oMkVSRc8gBWvF9F0fGWt a8zFJ6GHbEwP25Q0eGsTzQ+8afOa0cluwG5kBEVWaW6UdUsxVsWTMAidSR3l3WOfSFJiLJ bf4XmTj22uu9dWzbX9S29TBc/b9tcEIegBZaOtVOi5SzQVpRsVixUsSlvg8pRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Bp5rJzQB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672648949; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kSezthQeTZI6dbJpXn2kK9QIhRWnbb9PWtgL5Ru3Qxg=; b=jj/tMhUj4hT1PaJtIWEJCOE0zVqr+yWsPtS/0Dq40pJw5S4bJK5hCK0KHJeObgrWoN20lu reFIRjqnGx2vfrZS5+aEIvT/ifvaISHO5Gzje0bbmrsO4jP9yf6ARSnzePL8Ewb5WwbED7 FhQLW5ZQIriAyMyq4lO15RszmGky/u29t5hDYd8SILAnmuzLFK8YMkqRUzrnv6cchxBBQx m4/soCV7Sg4bP356ZTDaXqslW70C/t4lnT2fR3bVYbtIHGrt41f02EQjzS1LLYk6Yntjdc Tn+kXYrR7u/Vre7foHhkTlTWgjt+z0lxliC4qrZWmnGflwwFLftCqOOw47D3sw== X-Spam-Score: -8.09 X-Migadu-Queue-Id: 183DF1935B Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Bp5rJzQB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -8.09 X-TUID: yOZ/U3fGmLih Ihor Radchenko writes: > Ihor Radchenko writes: > >>> There is a race condition between writing the contents of the graphics >>> file to disk and emacs checking the file size. My guess is that this is >>> causing the problem (and that the same failure applies for emacs-2{6,7}, >>> since only the emacs-28 reports the exact test failure). >> >> Maybe we can just add several `sleep-for' calls to the test? > > I just did this. Let's see if CI errs again. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e5c45358a Apparently, `sleep-for' 1 second was not enough, and I decided to remove checking file size completely. Upon doing this, another failure popped up. This time, it looks like an actual Elisp issue: https://builds.sr.ht/~bzg/job/914954 2 unexpected results: FAILED ob-octave/graphics-file ((should-not (get-buffer "*Org-Babel Error Output*")) :form (get-buffer "*Org-Babel Error Output*") :value #) FAILED ob-octave/graphics-file-space ((should-not (get-buffer "*Org-Babel Error Output*")) :form (get-buffer "*Org-Babel Error Output*") :value #) As you can see *Org-Babel Error Output* buffer does not exist when running the test. Leo, could you please take a look? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at