From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8IZSLJDC0WTd6AAASxT56A (envelope-from ) for ; Tue, 08 Aug 2023 06:20:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kFwyLJDC0WSYEAEAauVa8A (envelope-from ) for ; Tue, 08 Aug 2023 06:20:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47957368F8 for ; Tue, 8 Aug 2023 06:20:32 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=jvKxqvGT; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691468432; a=rsa-sha256; cv=none; b=KKEtzUqrujlSsdSsOav6QrUbWiGHV8c49sJp85jUEptfAZt/pmrHa6WFFwYS+0rH7maajy s5Nyb5KBFmpNjmbrxg6qU1rmFWNv8p0Zo458wZjiW6NwvhA+J2FWnmkNZnyDVRfv5GdCBZ slAlfWLhZCLkcK2iewnOGIMtZbP0KUzRAmEDs3PGI6p3e27ckLVp98KIXvR4seFVK3xS8t 4VOJetf7a5cevVTNCup3Aic85OwlJCKfhhtZq38spHw8cJKn56jmvTkpaTnQ59gjeuGGzo uWFT+i5YvhfU0UMb30WjcBYDzoWWGexQ6QRT3L5rFq1nNKY98zVQD6W5F9cQ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691468432; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=0TJTEoTpRW/L3MBpeYl3ZTK/zZ4jSJgkR8DzDguC58g=; b=OLZUxTBNX7HTjVtV9i4g7RcY2zcm97ZOlH+N1u8vIN+AL2Z6edZoW2U2oPC652BugQZQ8c VcYrXLyoTz22t1/d4gcSdMZ3pdFI5W2VGURTtophxLVRy8c27gaz8GqFUPm1HELP/1l2mJ bFbyXoGpvMeRDg7MFTf7FU9F3MFEdi8MRGZhB/CQeiVuZMEzRk1FK/HenVhAeAourgMKST Tu5uUZ5S9CXHH/1qjS6TxilQe8OV3jzmGODZfyRnZVEfYKrQ5hbyvQXVSJZT6odKhnUBQX kNtcwCJzorKUoFcK6qA6Pbq9yCpkBfYl0qoGYy+15zX5dejWBVqVp5E2ABiM7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=jvKxqvGT; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTECC-00067F-EL; Tue, 08 Aug 2023 00:19:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTECB-000673-Hf for emacs-orgmode@gnu.org; Tue, 08 Aug 2023 00:19:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTECA-0007Bh-Ji; Tue, 08 Aug 2023 00:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0TJTEoTpRW/L3MBpeYl3ZTK/zZ4jSJgkR8DzDguC58g=; b=jvKxqvGTqkhh67GoBuZS KE6i/zNsHHJNTGGfFv9ZWGs/5sdA7F0tb3SStMa4mNzsGxsf9f1aUItVLrdFpQJ/SzliXY6fIUNQA 3VtoM/ejg6V9xup5hwBxb19BPupZ+hgGCJm2ZBpxOSIyAShNfZ/Fz/6L545RdLuNZ+8cvm8Ob/O7C S9T52Vwv3VtPLqBKbRZ4iFopKqKjQU5KjNaYxrJxg8qcKL9tBaKwyTLqhueJscRW4rKT79Xuz+p0B IlQe0wsYiWSi0ezxNXKdy9N5YQeZiUaVM8USZ2+YVwgFxirs++xLrB0dYcJ0X/6Qgf+eeIi1dOH93 ljnC+65GgdugaQ==; From: Bastien Guerry To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [POLL] Should we accept breaking changes to get rid of Org libraries that perform side effects when loading? In-Reply-To: <874jq8ohbr.fsf@localhost> (Ihor Radchenko's message of "Sat, 25 Mar 2023 17:45:44 +0000") Organization: GNU References: <87o7omg4ie.fsf@alphaville.usersys.redhat.com> <87pm91ngb8.fsf@localhost> <87jzz8f3re.fsf@alphaville.usersys.redhat.com> <87mt43agk6.fsf@localhost> <874jq8ohbr.fsf@localhost> Date: Tue, 08 Aug 2023 06:19:43 +0200 Message-ID: <87bkfip3mo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.88 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 47957368F8 X-Spam-Score: -6.88 X-TUID: 70eOSF+FWxTT Ihor Radchenko writes: > Max Nikulin writes: > >>> Sure. This is not by itself a big deal. A number of Elisp libraries, >>> including built-in Emacs libraries are loaded with side effects. >> >> It is still violation of conventions: >> >> (info "(elisp) Coding Conventions") >> https://www.gnu.org/software/emacs/manual/html_node/elisp/Coding-Convent= ions.html >>> D.1 Emacs Lisp Coding Conventions >>>=20 >>> Simply loading a package should not change Emacs=E2=80=99s editing beha= vior. >>> Include a command or commands to enable and disable the feature, or to >>> invoke it. >>>=20 >>> This convention is mandatory for any file that includes custom >>> definitions. If fixing such a file to follow this convention requires an >>> incompatible change, go ahead and make the incompatible change; don=E2= =80=99t >>> postpone it. > > This is convincing. > I am then CCing Bastien, as, despite the Elisp convention, following it > will break https://bzg.fr/en/the-software-maintainers-pledge/ FWIW, in this case, the mistake lies in breaking the Emacs Lisp coding convention first. When the breaking change is a side-effect of fixing a bug, it is unavoidable. --=20 Bastien