From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yGz0MGOzzGWLowAAqHPOHw:P1 (envelope-from ) for ; Wed, 14 Feb 2024 13:34:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yGz0MGOzzGWLowAAqHPOHw (envelope-from ) for ; Wed, 14 Feb 2024 13:34:43 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gzAYi9Az; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707914083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QOC94KzmL+YBBN2iLzMVSHQ9VpH4I3q7MBLrJNbalko=; b=md+Q56b4kLYtbMdxjdTT2B4cxo1kZOpF3B083+alTupAerv75lc8Ttw9kBbDypv4yuoMZO J7iRaJ9bfxmDo2CDAN5WmRxg9ih+1Nc210akFstg+L7JIsvYyBB6hOGXrb+HdcT2LXWns/ H+jY6CD4b/VoWuEAkjx8/VdpoLWJCq05LYod/tKd0svrNlU+WdF3txzpJUfc2FrwkZ9WtU ppU37JzFU0OtRan528wT1u+N9/yMzibWwbUwe4I49RMNxA2hxLWbuAkWC19H3vZ3jX87eZ f3oSGiCIA4QGo7DVIZt75nPpmx2UfD9PLHOBC9TQ7XB7f+Az5KtShcseikZI/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gzAYi9Az; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707914083; a=rsa-sha256; cv=none; b=Dt5Ov24Zdoi0SQeGbVLIzRm4xLNU6FQsA50HhsbdGZjJmbZZKVnm34gOB+EDL5Oe9iHHH7 oqKXo2M0r5zV3C9gSCg6aV3nt21cT80C+NztpCM2DsovLACaOgrwoehQp+hirN+sr5Fvob GHwEFqF1r/KhszsMsd6+E1YUu5/x8q0yIQlWTGkU1uD6yiOpp4xd+u1UXPH6ekWfb2arBO Qw+W2PHNL5cYT8UG04Yu3ABPV6F/+aip2AjC7tVfsKiyeqypCKNVzcGDzTHeX7ydSScNje /LqYDFECCnTyB3N1AWq2GKe5I/yxsqHBmIlZva/WRr/bUlNmdwfSDADxbJh7uA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DC3E37907 for ; Wed, 14 Feb 2024 13:34:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raESK-0000Mq-6w; Wed, 14 Feb 2024 07:33:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raESI-0000IW-7J for emacs-orgmode@gnu.org; Wed, 14 Feb 2024 07:33:38 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raESG-0001OR-2l for emacs-orgmode@gnu.org; Wed, 14 Feb 2024 07:33:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 55F60240105 for ; Wed, 14 Feb 2024 13:33:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707914012; bh=JqdzylkSQfcHcVNY+LdYQoe3mQB2pOcRdHoW0mAnw2U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=gzAYi9AzAAaVmwG/S886GiAUx9F2SNJN7S08anfyT7NqChEkXr26sUuY9QLPk9MBd xYG02xDV1n2X5WBkfNWolbnkzsX4QXHUx0N8P/V6yKZbs3OLS4hy/GspFT3gZk3nvV A5hHtXh6J8sj58A3iXNgckoB9xj5lyNNLCJQcFOdeWNEFoYkcMBOcZ8I1XT0VIWsdP RU9Egaz/gXEM5asLO8Y/6kcu+pu2eZi9+D/SrMpJk89KeH3IBP6FY9UVFqiDY8Tfbq h0oH4/qFA2hjahtsH4qT0FpgoeGD3rGaZ55MEQT6WkIbiJ7CnKF+dNSGe56iWJwu4u H/mReIdmzEy+w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TZd0C2v3Bz9rxK; Wed, 14 Feb 2024 13:33:31 +0100 (CET) From: Ihor Radchenko To: Anders Johansson Cc: Nicolas Goaziou , org-mode-email , Timothy Subject: Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items In-Reply-To: References: <87wnosb9rc.fsf@nicolasgoaziou.fr> <87k0k1oh05.fsf@gmail.com> <87zgsx5upu.fsf@nicolasgoaziou.fr> Date: Wed, 14 Feb 2024 12:37:07 +0000 Message-ID: <87bk8jusr0.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.72 X-Spam-Score: -6.72 X-Migadu-Queue-Id: 9DC3E37907 X-TUID: Y/b5GkxELl5p Anders Johansson writes: > Included is a patch for the filtering (I assumed cl-intersection was > reasonable to use since cl-lib is a requirement). > > However, I do not think this is enough, since it can cause quite > unexpected results when canonical is used without specifying the > format, Hence, I do think the previous patch should also be applied. > > For my case, org-duration-format is (("m") ("w") ("d") (special . h:mm)). > This call to org-duration-from-minutes (like in org-agenda-format-item): > > (org-duration-from-minutes MINUTES nil t) > > will then result in a full format amounting to (("d")), (since > "special" is not part of the canonical units), which is hardly what is > expected for the agenda. The patch breaks tests and thus cannot be applied. May you please provide more details about the original problem you were trying to solve? Preferably with a reproducer. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at