From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] bugfix: fix previewing latex fragments with imagemagick
Date: Sun, 14 Jul 2013 10:35:30 +0200
Message-ID: <87a9lplest.fsf@gmail.com>
References: <CAJpRBmf6dj=PvJZ79XspYgDsNbov9Kjmj1wrjJ3Qy=mfSyvxmA@mail.gmail.com>
	<CAJpRBmc_0=OcanCj2=4A_dVOS=fbJfUZ6hv0w5D4TwjSMGa3Vw@mail.gmail.com>
	<87ehb1lf31.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UyHm3-0004V3-HJ
	for emacs-orgmode@gnu.org; Sun, 14 Jul 2013 04:35:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UyHm2-0006Sg-RJ
	for emacs-orgmode@gnu.org; Sun, 14 Jul 2013 04:35:19 -0400
Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:50554)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UyHm2-0006Sb-Lh
	for emacs-orgmode@gnu.org; Sun, 14 Jul 2013 04:35:18 -0400
Received: by mail-wi0-f170.google.com with SMTP id ey16so1955392wid.3
	for <emacs-orgmode@gnu.org>; Sun, 14 Jul 2013 01:35:18 -0700 (PDT)
In-Reply-To: <87ehb1lf31.fsf@gmail.com> (Nicolas Goaziou's message of "Sun, 14
	Jul 2013 10:29:22 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: feng shu <tumashu@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Correcting myself:

Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
> feng shu <tumashu@gmail.com> writes:
>
>>         (unless (and (org-check-external-command "latex" "" t)
>> -		    (org-check-external-command "dvipng" "" t))
>> +		    (org-check-external-command "dvipng" "" t)
>> +		    (org-check-external-command "convert" "" t))
>
> There's a missing `or':
>
>   (or (org-check-external-command "dvipng" "" t)
>       (org-check-external-command "convert" "" t))

Err. This is still wrong.

Use 

  (and (org-check-external-command "latex" "" t)
       (org-check-external-command
        (if (eq processing-type 'dvipng) "dvipng" "convert") "" t))

instead.

-- 
Nicolas Goaziou