From: Kyle Meyer <kyle@kyleam.com>
To: Viktor Rosenfeld <v.rosenfeld@gmx.de>
Cc: "Gustav Wikström" <gustav@whil.se>, emacs-orgmode@gnu.org
Subject: Re: org-agenda-filter-by-tag-refine defaults to exclude
Date: Tue, 12 Jan 2016 01:18:36 -0500 [thread overview]
Message-ID: <87a8obl3r7.fsf@kyleam.com> (raw)
In-Reply-To: <29B5D2C5-E59B-4E8D-9669-67F24C0B7C60@gmx.de> (Viktor Rosenfeld's message of "Tue, 5 Jan 2016 08:42:20 +0100")
Hi Viktor,
Viktor Rosenfeld <v.rosenfeld@gmx.de> writes:
> Hi,
>
> I noticed that org-agenda-filter-by-tag-refine started to exclude
> selected tags by default recently because the 'refine in the call to
> org-agenda-filter-by-tag is interpreted as an exclude flag.
This seems to have been introduced by 6c6ae99 (org-agenda: Filtering in
the agenda on grouptags, 2015-01-24).
> The attached patch fixes this.
>
> However, it seems that the function is superfluous because
> org-agenda-filter-by-tag can filter on multiple tags as well if called
> multiple times (that used not to be the case earlier). So maybe it
> should be deprecated and removed?
I agree. Gustav, does that make sense given your changes in 6c6ae99?
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index d91b64d..21928de 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7580,7 +7580,7 @@ to switch between filtering and excluding."
> (defun org-agenda-filter-by-tag-refine (arg &optional char)
> "Refine the current filter. See `org-agenda-filter-by-tag'."
> (interactive "P")
> - (org-agenda-filter-by-tag arg char 'refine))
> + (org-agenda-filter-by-tag arg char))
> (defun org-agenda-filter-make-matcher (filter type &optional expand)
> "Create the form that tests a line for agenda filter. Optional
--
Kyle
next prev parent reply other threads:[~2016-01-12 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 7:42 org-agenda-filter-by-tag-refine defaults to exclude Viktor Rosenfeld
2016-01-12 6:18 ` Kyle Meyer [this message]
2016-01-28 8:27 ` Gustav Wikström
2016-01-29 23:07 ` Viktor Rosenfeld
2016-01-31 18:50 ` Gustav Wikström
2016-01-30 0:57 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8obl3r7.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=gustav@whil.se \
--cc=v.rosenfeld@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).