From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] add :session support for ob-js.el
Date: Sat, 17 Mar 2018 12:14:26 +0100 [thread overview]
Message-ID: <87a7v7dkdp.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <307cac72-36e9-0ba6-262b-a12f291953a0@gmail.com> (stardiviner's message of "Tue, 13 Mar 2018 19:51:38 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> updated my code. I followed your suggestions. But modify code one by
> one messed code up. So I merge all related commits into one commit.
> Sorry for this.
Some comments follow.
> + (result (if (not (string= (cdr (assq :session params)) "none"))
You can integrate the test above in the `cond':
(cond
((string= "none" (cdr (assq :session params))) nil)
((string= "*JS REPL*" session) ...)
...)
> + (sit-for .5) (goto-char (point-max))
(sit-for .5)
(goto-char (point-max))
> + (mapc (lambda (var)
> + (insert var) (comint-send-input nil t)
> + (org-babel-comint-wait-for-output session)
> + (sit-for .1) (goto-char (point-max))) var-lines)))
> session))
(dolist (var ...)
...)
Also, what's your status wrt FSF papers? This cannot fit as
a TINYCHANGE.
Regard,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-03-17 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:02 [PATCH] add :session support for ob-js.el stardiviner
2018-03-13 8:43 ` Nicolas Goaziou
2018-03-13 11:51 ` stardiviner
2018-03-17 11:14 ` Nicolas Goaziou [this message]
2018-03-17 17:51 ` About the assignment of FSF papers stardiviner
2018-03-18 16:15 ` Nicolas Goaziou
2018-03-22 18:47 ` stardiviner
2018-03-24 19:02 ` Nicolas Goaziou
2018-03-25 3:31 ` [PATCH] add :session support for ob-js.el stardiviner
2018-03-25 21:09 ` Nicolas Goaziou
2018-03-26 1:40 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7v7dkdp.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).