From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gJFYMSZVW2P7XwAAbAwnHQ (envelope-from ) for ; Fri, 28 Oct 2022 06:05:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yA5XMSZVW2PLWQAA9RJhRA (envelope-from ) for ; Fri, 28 Oct 2022 06:05:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81BA437D91 for ; Fri, 28 Oct 2022 06:05:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooGbx-0008F5-L3; Fri, 28 Oct 2022 00:04:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooGbv-0008Ey-K8 for emacs-orgmode@gnu.org; Fri, 28 Oct 2022 00:04:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooGbt-0002nT-CP for emacs-orgmode@gnu.org; Fri, 28 Oct 2022 00:04:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9E0AD240027 for ; Fri, 28 Oct 2022 06:04:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666929883; bh=M4ya8uUIqCw+Dbm73IEvMpsAe3hD4AiJOCX26OVW6Ys=; h=From:To:Cc:Subject:Date:From; b=GhOG3h8i1U9pyK6pm3ghLaToITO2lXL8UYscAdkYsCQCSTbVLZPOp7RapatUcBx3p +Ba34qNvlfvlVQd9t00aU5VUIDMYSsLyGmu9CF78Fnl06hBWDnkqp65bvm8x6zjopi ZwyQGCceWjIkM2MTxY021vCyBk2qIi+xC6zPxyj9WH/S/EmDm3dIZ6TlSerF2ca+rX 781Rs+sN7kljvkXG+W5A3wRKWAHYw4IWurcVKf97joilgQDhVE0SAC7a7n/Mmd1g+J Vb3rDz8HY93UIrQvE2qY64j6Xi1iR71PyZSMP8IuOYxZXlaBfUUBBaH+m87qgZp2ql rPvMZ2vmNZ5+w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mz87s37Dlz6tmW; Fri, 28 Oct 2022 06:04:41 +0200 (CEST) From: Ihor Radchenko To: Daniel Kraus , Bastien Cc: numbchild@gmail.com, Org Mode Subject: Re: ob-clojure eval error when has comment at end of code line In-Reply-To: <878rl1a1e0.fsf@kraus.my> References: <87lep3oxcu.fsf@localhost> <878rl1a1e0.fsf@kraus.my> Date: Fri, 28 Oct 2022 04:05:24 +0000 Message-ID: <87a65gmw3f.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666929958; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=drbySkCGHWtu5syifv+xxRU0xvaDq+ItIv3W6OFvSIk=; b=kmfANClLZvW4ewjtYLV1dFSbEe8X+n0H/ibIYwtqKJ5zWe/XJxgEd73yMCal1iQDh24P/s fjJHPKtRC6maY1Noj7X0MF9kN1VbnNiH4BFgqc7JjCdLo41jItsilEy35ulo78GqjjL6dG AGoJ+wNcPrTO6HLOkhDWi7E+WAtraq+g2z7Wuyo6pfAijSH2AMDHARHx7928W7HpBHjMIc JA4nFyTggHp5wIuLh7jMovILRL0kDIra3+0o3ETEa15xLGrFbkub9DAGed8m55omVJuwUs vlwahaW4Crgla/FnfwXT61vdTtPdYP77IlGwQfRvBmV4/FxaunFI24FvXmUEGA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666929958; a=rsa-sha256; cv=none; b=rTqbrvycUJgG1FXnbdwTPyxovNPVaBGow5ifJhibjNloTytZTsLfTslMhkVe+dNjq2PMNi OpzRi/zsQHoekLryHmphRrEwoanp1vRsKhHDNArrReH02XzbwKLFKsVG1fbj4jScFco8bR xZ2n2zffAneLwbOo/gJz79KuwsZ7MSeCmhQlsAx/aWccNQu8RGDTKww3Uq9I5sis02iV4b SduQk702T8MImLwMso1AFJrDeRyfyWVkVcbk6TUcSA/FihApHnR+VCDZ8SUk4iRzc0FE5t WqKyXqTvzCyzjuGZ5eWXliXuCHencwgNQRtIcB2+1Zm4nvTML3SU3Pkg4CcUJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=GhOG3h8i; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.41 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=GhOG3h8i; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 81BA437D91 X-Spam-Score: -5.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: BsXotLcG5kxd Daniel Kraus writes: > @Ihor, a few developer related questions: > - I wanted to add a test, how can I run only test-ob-clojure? make test BTEST_POST="-L /path/to/cider.el" BTEST_OB_LANGUAGES="clojure" BTEST_RE="ob-clojure" Note that our tests demand cider executable and library. Testing with external libraries is a bit manual. > - What should I use for indention? Looking in ob-clojure and org.el > it seems that using tabs with tab-width 8 is standard but there's > quite a few lines where it's spaces only. That is a good question. I guess, just Emacs default. Our code is not consistent here... Maybe Bastien can clarify better. > - If this simple patch for example or fixing tests is good, > should I just install it? Yes. We have some conventions documented at https://orgmode.org/worg/org-maintenance.html#maintainer-role > Can I "freely" install minor changes to ob-clojure or should > everything go over the mailinglist? Minor changes do not need to be discussed. We generally discuss new features or changes that affect multiple libraries. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at