From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QCgrA3vJXGOGawAAbAwnHQ (envelope-from ) for ; Sat, 29 Oct 2022 08:34:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IP4kA3vJXGNgjAAA9RJhRA (envelope-from ) for ; Sat, 29 Oct 2022 08:34:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B794722EF7 for ; Sat, 29 Oct 2022 08:34:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oofQ0-0004IB-GH; Sat, 29 Oct 2022 02:34:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oofPw-0004Hl-V4 for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 02:34:05 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oofPu-0001Vg-L7 for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 02:34:04 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 015AD240026 for ; Sat, 29 Oct 2022 08:34:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667025241; bh=xxrQHTIRV97xlbYvl0AZyaxeCShoKKYUVuBnKbYUgiA=; h=From:To:Cc:Subject:Date:From; b=i+PrI7ZOjwhL4Nf1ExETLbyFIZktt80eNfO6UGiRtNZsd9TVOMOZG3ppWnjTq9puw NS/P4sJ3al6STXRM94zDsTrT7GkwhKGo8Q/eP8pE/DxiNhPyTmnxXVjgiXiSDPlYjw KB3i62yKx3tow024i33Pgok0u7+kPCXNGBsFpSuja5FifpuVcqHDnvWyQECU5H9MUT IZ55qIjZ1CIZrUrp+DKWwnC60YCxgh9aO1zDIVcHRRiHEBFaeis6GMEvbvH5bMwJeD 3J49cY86koeHxAUcGLOO19c18esGPKUuDlxZezd6+9vhSvzKubm4EgBONUb6c+Ggqg ydffLmF+HPbeQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MzqPg0tNtz6tpl; Sat, 29 Oct 2022 08:33:58 +0200 (CEST) From: Ihor Radchenko To: tbanelwebmin Cc: Org Mode Subject: Re: Please add support for dlangs packagemanager to ob-C.el In-Reply-To: References: <87ill8sg77.fsf@gnu.org> Date: Sat, 29 Oct 2022 06:34:40 +0000 Message-ID: <87a65fi1dr.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667025274; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8VXTwwDIf1il0qJiQfe1waqdKddB3Yja3aaxeRjkJ5o=; b=IDweHsC4YR9F6PhUhHKH6PZkJ46Eksf+AXyGa4CbkxWqgkoXKfnHdIP+51JebKEXoIKJgt SZwZmjBCollAi8n+hHXMxOvXWQ0qDx/WhdyMjtnapBrq93fhWxnS+NUlvs+iE4i/gSo/AL MCWr1r4FinwacmLeiMtZ+NGSBQY7pNMxiyizcqFS3lcx+I0aiUpDhi26J0+0pvXYH6tmN4 5NdkanW3K1sKcmlOAkMZf87LG47kHjI3hKDS7Ui+yrF9zklzHRIbEUxPZOBRqOiXZSKGEl HdmhmrvOtAm7iU/OVGglEvd5PPoXgQKLFrkqrhhxdnK87EMtlF/VAhT6+RJczw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667025274; a=rsa-sha256; cv=none; b=TR2pSA7Yu1WRqIaEuQ0nEGSSlowSBaoXHOrX4UAXTGXB4FaU/bW813ji1VtPTw6RPvc1yV ts+vnjsH1P+qhcJuJA5nLQ16oFh5O0ZNwaZPW6x3BJpxv34Dx+7DSahRTPzGAsFXVob/PP pLKOeQKA/P53E8vGRLzPvd2zAcs5x8EOAPJ4Nj2V5io8ZHTFW7hQ4yJwYMIgnb2Ixw9Pw6 E3puA+Mw52cQ0kpSnOXEurnqCKoYi2oDG3xD7HQccYW6Ft+Ppxg/vukibG6U/IlR33SrhY 9VLBqZJFKVqYQOUVkI0aIqejEBb4osgiJwzs48BmRNngR78oDYLJlAb4U6zEcw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=i+PrI7ZO; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=i+PrI7ZO; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B794722EF7 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: RCr5OnZnm2ae tbanelwebmin writes: > Your TINYCHANGE fits into the 15 lines limit. I will review it. > > As Bastien said, we follow as much as we can a predefined format for commit messages: > https://orgmode.org/worg/org-contribute.html#commit-messages > > You may also look at past commit messages, for instance this one: > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a6a56c804099e358ca558119b7aede0b2b9b90f > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/ > > If you want to further contribute, maybe in another TINYCHANGE, automatic unit tests are very valuable. There > are already examples of Dlang tests in: > testing/examples/ob-C-test.org > testing/lisp/test-ob-C.el Thierry, do I understand correctly that the only objection if the commit message format? If so, I can fix it and apply the patch. Will it be ok? (One month has passed since your review and no response has been given. Since the patch is useful, we may as well take care about such a small issue as formatting) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at