From: Ihor Radchenko <yantar92@posteo.net>
To: tbanelwebmin <tbanelwebmin@free.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Please add support for dlangs packagemanager to ob-C.el
Date: Sat, 29 Oct 2022 06:34:40 +0000 [thread overview]
Message-ID: <87a65fi1dr.fsf@localhost> (raw)
In-Reply-To: <f5448c14-9ad0-25f8-d54b-58d31c9b075c@free.fr>
tbanelwebmin <tbanelwebmin@free.fr> writes:
> Your TINYCHANGE fits into the 15 lines limit. I will review it.
>
> As Bastien said, we follow as much as we can a predefined format for commit messages:
> https://orgmode.org/worg/org-contribute.html#commit-messages
>
> You may also look at past commit messages, for instance this one:
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a6a56c804099e358ca558119b7aede0b2b9b90f
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/
>
> If you want to further contribute, maybe in another TINYCHANGE, automatic unit tests are very valuable. There
> are already examples of Dlang tests in:
> testing/examples/ob-C-test.org
> testing/lisp/test-ob-C.el
Thierry, do I understand correctly that the only objection if the commit
message format? If so, I can fix it and apply the patch. Will it be ok?
(One month has passed since your review and no response has been given.
Since the patch is useful, we may as well take care about such a small
issue as formatting)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-29 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 20:38 Please add support for dlangs packagemanager to ob-C.el Christian Köstlin
2022-09-27 20:41 ` Bastien
2022-09-29 19:53 ` tbanelwebmin
2022-10-29 6:34 ` Ihor Radchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-08 22:47 Christian Köstlin
2022-03-10 8:24 ` tbanelwebmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a65fi1dr.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=tbanelwebmin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).