From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GPEHOhs6uGOKgQAAbAwnHQ (envelope-from ) for ; Fri, 06 Jan 2023 16:11:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6G8JOhs6uGN+NgEA9RJhRA (envelope-from ) for ; Fri, 06 Jan 2023 16:11:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FB6C2A8FF for ; Fri, 6 Jan 2023 16:11:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDoMm-0002XN-U9; Fri, 06 Jan 2023 10:10:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDoMl-0002XB-B2 for emacs-orgmode@gnu.org; Fri, 06 Jan 2023 10:10:43 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDoMj-0001Sn-DE for emacs-orgmode@gnu.org; Fri, 06 Jan 2023 10:10:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 668E82403B1 for ; Fri, 6 Jan 2023 16:10:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673017839; bh=9Chnqj1E8l0S/9t07R+DZoBHnVypBuQEltdAe0A1qh0=; h=From:To:Cc:Subject:Date:From; b=hjyl8ZwtAVH/ViSviLK4pfZlUCh8ZkZbKW4Kp4IcJSHjefzDjE/MiuIPZRhoU4Elq koRt8LrpJqQawBkJ1KQp2XpODW2SlCMDnnTKRH+M+O3BVViUWBi9/hpNe+829bhIOG r/qmrPJ8tEjPIKMROYTkbTyKgO3kjOQH5XT3mpAB0PWivdu4buOF9MRSM44z/YfWpk Gcj2dGZ684IeM9YlTY3nSgLedmcFWhhJz2l3O0r29i6jHlvCr87zRDEj/7G9unKl+/ O1vvbzdCXvkw5UvPTkLnPhFrq3tveC1WCDAoEcOGRCuNLPXCT4MYNK1KK6jOqtqsl0 lJ/FWSqkh+lew== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NpRbw2jBXz9rxH; Fri, 6 Jan 2023 16:10:36 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87358ovj53.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> Date: Fri, 06 Jan 2023 15:11:09 +0000 Message-ID: <87a62vitpu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673017883; a=rsa-sha256; cv=none; b=UxdsUkbpLKcePxJBMg9gCtHQcmFhXRHF16do7JxLY4ijr7C3pCI5AhfBRBSjk/gmJEWkIr Fnmp3d4MQBPZu78ToHfkohAcHYCz7faypcKcF7l9jJ/i6ApJBWDXlDxCuJYI6tVZ7wEgpB vtJqfq/XNRldwjRR2ww2UhLKTwaWDQkZjilrTXramu2ZtKwu6hZomiMQrCIxOyBFxFiSYN 5rsMIMEtIwJZr0UBIWbvtWxKaXR+/DH5x5/0Aw/skN7WST4BoOYct0AlJvod89fKnBoDP3 y7T1A6DxeE8waBJCKpshLhEtPQ5Tp5Bxiu5nZHTm+BHKFjb0y/5MIOivvsdFCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hjyl8Zwt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673017883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=MNP9Xyp9ey+jp7YGtu6xqiR9wOrjwGyDXSaveDs1sVU=; b=GTrMN0zNTFgjxTBfLCgp5VQ088cgFh51GbBXjO2VOLjm/oZ9V6XaN7xPGJgmJv1hgQMss2 Kykir7I9tiC589/n0mv0naVO+/7IsyMdnut8M07nY9GFniyneYaq/HfbECt8waHyOKl2II KR/l+Z9JCNVz9EFzD2EL2NErQWTHeWLZLHp2vbktaP3nlH0FVno0aR2fnDJfql/TuGfmZJ Q6gzQs1BGMrmJetyDB/NFPrLsgRa6hrMiu0sgmbYEyvgAzTto1RDGs0gY58F/kN4xjHE3t hSJLhTJy33KJG/xiKAEzL3BysXIkGRSVbuFLDP2u+6GM8Zjj8sHTiyhMDLH/uQ== X-Spam-Score: -6.30 X-Migadu-Queue-Id: 6FB6C2A8FF Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hjyl8Zwt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.30 X-TUID: 85wcToCjPgGg Leo Butler writes: >> Apparently, `sleep-for' 1 second was not enough, and I decided to remove >> checking file size completely. > > Hello Ihor, > > Is there an environment variable that could be used to determine is the > tests are being run on sourcehut? This would let us cut out that test on > sourcehut, while still keeping it elsewhere. No, we have nothing like this. In theory, we can bind something in https://git.sr.ht/~bzg/org-mode-tests/tree/master/item/.builds/init.el, but I am not sure if it is a good idea. The tests are failing not because something wrong in the CI machine, but simply because CI machine is slow. You can get similar issue when running Org tests on an actual proper old PC or simply when someone is running CPU-heavy process alongside with Org tests. So, I do not think that creating exceptions for CI is a good idea. >> https://builds.sr.ht/~bzg/job/914954 >> 2 unexpected results: >> FAILED ob-octave/graphics-file ((should-not (get-buffer "*Org-Babel >> Error Output*")) :form (get-buffer "*Org-Babel Error Output*") :value >> #)=20 >> FAILED ob-octave/graphics-file-space ((should-not (get-buffer >> "*Org-Babel Error Output*")) :form (get-buffer "*Org-Babel Error >> Output*") :value #)=20 >> >> As you can see *Org-Babel Error Output* buffer does not exist when >> running the test. >> >> Leo, could you please take a look? > > An earlier test is creating that *Org Babel Error Output* buffer. That > is killed on the first test, before the test is actually run. But > GET-BUFFER behaves in an undocumented way: it returns a non-nil value, > #. To remedy that, I have wrapped the calls in > BUFFER-LIVE-P. This is not undocumented. The killed buffers still exists as Elisp objects: 28.10 Killing Buffers =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =E2=80=9CKilling a buffer=E2=80=9D makes its name unknown to Emacs and make= s the memory space it occupied available for other use. The buffer object for the buffer that has been killed remains in existence as long as anything refers to it, but it is specially marked so that you cannot make it current or display it. Killed buffers retain their identity, however; if you kill two distinct buffers, they remain distinct according to =E2=80=98eq=E2=80=99 although both are dead. > See the attached patch. Thanks! Installed onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D41ebc2e40 --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at