From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] org-agenda tag completion works with ido Date: Thu, 13 Jul 2017 14:02:31 -0400 Message-ID: <878tjsdxl4.fsf@kyleam.com> References: <87bmopdkcy.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dViRi-0003er-4U for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:02:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dViRf-0001yr-1w for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:02:38 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:50862 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dViRe-0001xo-P0 for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:02:34 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nathaniel Flath Cc: org-mode List Nathaniel Flath writes: [...] >> I'm not an ido user, but testing with >> >> (require 'ido-ubiquitous) >> (ido-ubiquitous-mode 1) >> >> partial completion seems to work fine when I hit tab after calling >> org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you >> using some other package to get ido completion for non-file/buffer >> completion? > > The issue is that that 'tab' is required - in the previous version of > org, this was not required and 'enter' would do the completion for > you. I'm only using tab right after calling org-agenda-filter-by-tag to get to the initial tag prompt, following the instructions in the minibuffer. Isn't that always needed? Here is how I'm testing (with emacs -Q): * list TODOs with the agenda (org-agenda, follow by "t") * on an entry, hit "/" for org-agenda-filter-by-tag * hit tab to get to the tag prompt Once in the prompt, I can select a partial completion by just hitting enter. I've executed the above steps with two setups: release_8.3.6/org-completion-use-ido and release_9.0.9/ido-ubiquitous. I couldn't spot any differences. Hitting enter for partial completion worked in both cases. >> In this particular case, your change looks OK because I think all useful >> values should be in the collection. But I don't understand why you're >> not able to do partial completion without this change. Are you running >> into the same issue everywhere else that completing-read is called with >> a nil value for require-match? > > I haven't checked everywhere else - presumably. It'd be good to figure out why you're seeing different behavior than I am. Perhaps the steps I list above aren't the right steps to trigger it. Or maybe you have some non-default ido configuration. Or maybe the difference comes from an ido version mismatch. (I'm using the ido from Emacs 25.2 and ido-ubiquitous checked out at v3.14-4-ga1c2965.) As it stands, I can't reproduce the problem described in your commit message. -- Kyle