From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH] Add option to automatically align tags in agenda view
Date: Mon, 07 Aug 2017 18:04:42 -0400
Message-ID: <878tivt4p1.fsf@kyleam.com>
References: <87poc7o50r.fsf@alphapapa.net> <87bmnrthag.fsf@kyleam.com>
	<87k22fnr3o.fsf@alphapapa.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1deq8n-0003Xl-Dp
	for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 18:04:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1deq8i-0003L1-FV
	for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 18:04:49 -0400
Received: from pb-smtp2.pobox.com ([64.147.108.71]:63610
	helo=sasl.smtp.pobox.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1deq8i-0003Kb-8c
	for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 18:04:44 -0400
In-Reply-To: <87k22fnr3o.fsf@alphapapa.net>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Adam Porter <adam@alphapapa.net>, emacs-orgmode@gnu.org

Adam Porter <adam@alphapapa.net> writes:

> Ok, I've updated the patch.

Thanks.  A few more comments.

> (org-agenda-align-tags): Handle automatic alignment
> (org-agenda-tags-column): Add 'auto setting

You're missing the file name in the entries above.  Also, the entries
should end in a period.

> -(defcustom org-agenda-tags-column -80
> +(defcustom org-agenda-tags-column 'auto
>    "Shift tags in agenda items to this column.
> -If this number is positive, it specifies the column.  If it is negative,
> -it means that the tags should be flushright to that column.  For example,
> --80 works well for a normal 80 character screen."
> +If set to `auto', tags will be automatically aligned to the right
> +edge of the window.
> +
> +If set to a positive number, tags will be left-aligned to that
> +column.  If set to a negative number, tags will be right-aligned
> +to that column.  For example, -80 works well for a normal 80
> +character screen."
>    :group 'org-agenda-line-format
> -  :type 'integer)
> +  :type '(choice
> +	  (const :tag "Automatically align to right edge of window" auto)
> +	  (integer :tag "Specific column" -80)))

Since you're changing the default value, shouldn't you add appropriate
values for the :version and :package-version keywords?

It'd be good to mention this change in ORG-NEWS as well.

-- 
Kyle