From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4HawNGIJ415mRAAA0tVLHw (envelope-from ) for ; Fri, 12 Jun 2020 04:49:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qNyBMGIJ4173MAAA1q6Kng (envelope-from ) for ; Fri, 12 Jun 2020 04:49:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 325EF9401CD for ; Fri, 12 Jun 2020 04:49:38 +0000 (UTC) Received: from localhost ([::1]:47742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjbdH-00072W-Re for larch@yhetil.org; Fri, 12 Jun 2020 00:49:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjbcj-00072O-SZ for emacs-orgmode@gnu.org; Fri, 12 Jun 2020 00:49:02 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44929) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjbci-0005ND-BR for emacs-orgmode@gnu.org; Fri, 12 Jun 2020 00:49:01 -0400 Received: by mail-wr1-x444.google.com with SMTP id y17so8318290wrn.11 for ; Thu, 11 Jun 2020 21:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=z0sE5k2xbRQrliSbKIG5s2vJeH649ey/lc1uffANTOs=; b=ts/PfGP3RlkP48NM6uxhYrq+bixs48Sc95C2SQISdrq1MiFYb3TLOmMcnF4jHdlp+/ sOydNky1pS5myTgynpe20ezu24F2Nzz15q8pS8LPknO7eGAtklhmqRqbm6OO1lDNKr0V PyQ0rEH5JL9x3hWRzv/7RLzgsozJvi5i0oxFoLOesf48XGfGM7C219AIH4mEwWIVGPQS 7sv7f37nQGlIESl/Q2jZp6a+XsOQeSwRl4wUlrZwagy6AJeAd5frKsgjXJrKVNCwrUzr Cc5YiuPLRrd5H+VLtUpJnwHzV+442WbNT1DVuUHFjGE6pqyEARqN5WLBubIjJiuhrrcQ ZwvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=z0sE5k2xbRQrliSbKIG5s2vJeH649ey/lc1uffANTOs=; b=NNFK7yujd7mbaoelBBQcrySr/5n01pqqtNsPWv6kJoWFpSIkoDWC1hft28mdwSMosR oeenZ8tcoQCK+kTqVBZ1/JxtsqtUFrG0r/QFug+KzD3BAgKQfDvYTzhBE/2rbwoe3vgx ataKZL5svFpH6gY6VTxK0CSFTAzf0FSiWgPOTzV2x9TjPwvizZ3CTzMS85ufgH16cOkT dPEqJ+1AeGB1Cx3eQ91pAS8WxVUZQTBIVKel9smDPTCbB/F9it+RTrwIEGdyeoTq6AJE QLIjdT+sgLe1x1NPPf7O8T6w25b4hOgC0nqYY9n6W971z256QPdr/wzf8DVvZrWMBGHe MxHg== X-Gm-Message-State: AOAM531A1viUPSxAviwhBfi2H/q/upxjHZzu+84cm1J/PlvHLeTbVAzn OGTuv2063zlQU/pDlQ6Q5/Lr0A4= X-Google-Smtp-Source: ABdhPJzYG0yFmR9V0PD8lb4YTQGKGljoGCHYtSjediNmFEilT6DF2n2XFhez9T+r8i8cG8a0mnqDIg== X-Received: by 2002:adf:82ab:: with SMTP id 40mr12264593wrc.85.1591937333618; Thu, 11 Jun 2020 21:48:53 -0700 (PDT) Received: from thinkpad.localdomain (5.7.9.93.rev.sfr.net. [93.9.7.5]) by smtp.gmail.com with ESMTPSA id r12sm8454573wrc.22.2020.06.11.21.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 21:48:52 -0700 (PDT) From: Leo Vivier To: Nicolas Goaziou Subject: Re: [PATCH] org-element.el: Fix properties being upcased by parser In-Reply-To: <87k10h5m6u.fsf@nicolasgoaziou.fr> References: <87h7vl3l1v.fsf@hidden> <87mu5d7opp.fsf@nicolasgoaziou.fr> <87d0693gam.fsf@hidden> <87o8pt5onr.fsf@nicolasgoaziou.fr> <87ftb5l4rd.fsf@hidden> <87k10h5m6u.fsf@nicolasgoaziou.fr> Date: Fri, 12 Jun 2020 06:48:51 +0200 Message-ID: <878sgs28jw.fsf@hidden> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=leo.vivier+dev@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=ts/PfGP3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 2.09 X-TUID: gRi9qWjB+5jI --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Nicolas Goaziou writes: > Leo Vivier writes: > >> Yeah, I=E2=80=99ve reached the same conclusion, and I agree that we could >> mention the normalisation in a docstring. Do you want me to take care >> of it? > > Sure! Thank you. The patch is attached. HTH, --=20 Leo Vivier --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org-element.el-Update-comment.patch >From e96e96931109026f406b3cabb0186319e902aca7 Mon Sep 17 00:00:00 2001 From: Leo Vivier Date: Fri, 12 Jun 2020 06:45:32 +0200 Subject: [PATCH] org-element.el: Update comment * org-element.el (org-element-keyword-parser): Mention that `keyword' is normalized by being upcased --- lisp/org-element.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/org-element.el b/lisp/org-element.el index a5641e6ee..a693cb68d 100644 --- a/lisp/org-element.el +++ b/lisp/org-element.el @@ -2174,9 +2174,9 @@ the buffer position at the beginning of the first affiliated keyword and CDR is a plist of affiliated keywords along with their value. -Return a list whose CAR is `keyword' and CDR is a plist -containing `:key', `:value', `:begin', `:end', `:post-blank' and -`:post-affiliated' keywords." +Return a list whose CAR is a normalized `keyword' (uppercase) and +CDR is a plist containing `:key', `:value', `:begin', `:end', +`:post-blank' and `:post-affiliated' keywords." (save-excursion ;; An orphaned affiliated keyword is considered as a regular ;; keyword. In this case AFFILIATED is nil, so we take care of -- 2.26.2 --=-=-=--