From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MF6PDzWtcF/FaAAA0tVLHw (envelope-from ) for ; Sun, 27 Sep 2020 15:18:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sExhCzWtcF9ZRAAAbx9fmQ (envelope-from ) for ; Sun, 27 Sep 2020 15:18:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8BBBA9402DA for ; Sun, 27 Sep 2020 15:18:12 +0000 (UTC) Received: from localhost ([::1]:44276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMYRH-0007rq-D7 for larch@yhetil.org; Sun, 27 Sep 2020 11:18:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMYQr-0007rd-QJ for emacs-orgmode@gnu.org; Sun, 27 Sep 2020 11:17:45 -0400 Received: from udcm-wwu2.uni-muenster.de ([128.176.118.28]:32221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMYQp-0002BS-AI for emacs-orgmode@gnu.org; Sun, 27 Sep 2020 11:17:45 -0400 IronPort-SDR: khHvPHTlyXds6bOE1+aZV1IlD+30AUh2NVn2a93TzDgwbaOp/M6Z6WqbZ8zgOp+iH6IUw2VC9L f+juLA2xjPgYst4x/Bv0mCXdrUoigIEauWvPyt8Af2ObsHfQ3ipu/83NLRRxRO40xRTSfkCqrT 1UNYPdbCnmDf2CbmZEqFAJe31X2UU3YVhRbdpuqta2RttDKdgxRUhPNeqMGYggImVoRWNdZiFr v2akSrnJQIdKrFIlxc1f8V1Suq9HLFaVUdc7HBta3E3TZayKew/NBcibJHc1Bu8d5gxdeULdjn r5c= X-IronPort-AV: E=Sophos;i="5.77,310,1596492000"; d="scan'208";a="50813782" Received: from wi-exchange.wiwi.uni-muenster.de ([10.2.203.154]) by UDCM-RELAY2.UNI-MUENSTER.DE with ESMTP/TLS/ECDHE-RSA-AES128-SHA256; 27 Sep 2020 17:17:38 +0200 Received: from WIWI-MAIL-2.WIWI.UNI-MUENSTER.DE (128.176.86.149) by WI-MAIL-1.WIWI.UNI-MUENSTER.DE (10.2.203.154) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sun, 27 Sep 2020 17:17:38 +0200 Received: from librem (92.116.42.190) by smtp.wiwi.uni-muenster.de (128.176.86.149) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sun, 27 Sep 2020 17:17:38 +0200 From: Jens Lechtenboerger To: TEC Subject: Re: [PATCH] Enhance org-html--build-meta-info In-Reply-To: <87tuvl3fyc.fsf@gmail.com> (TEC's message of "Sat, 26 Sep 2020 01:48:44 +0800") References: <87pn6kfr19.fsf@gmail.com> <87v9gcz9ge.fsf@wi.uni-muenster.de> <87lfh8fkj1.fsf@gmail.com> <87zh5n1p3s.fsf@wi.uni-muenster.de> <87tuvl3fyc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) OpenPGP: id=0xBCD68E10; url=https://dbis-group.uni-muenster.de/dbms/media/people/lechtenboerger/0xBCD68E10.asc Mail-Followup-To: TEC , org-mode-email Date: Sun, 27 Sep 2020 17:17:32 +0200 Message-ID: <878scvs0z7.fsf@wi.uni-muenster.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [92.116.42.190] Received-SPF: pass client-ip=128.176.118.28; envelope-from=Jens.Lechtenboerger@wi.uni-muenster.de; helo=UDCM-WWU2.UNI-MUENSTER.DE X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 11:17:38 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 5QMgXkcfYONy On 2020-09-26, TEC wrote: > @Maintainers I think this is ready for a review. > > Jens Lechtenboerger writes: > >> My suggestion would be to go with the handling of description in all >> cases, including the title. > > Currently the only element handled differently to > `org-html-encode-plain-text' is "author". I don't know why so I don't > want to touch it. I believe that was also the previous conclusion. However, as this is not documented, maybe now could be the chance to change this? >> I added keywords to my OER presentations because some crawlers use >> them to extract topics for classification of documents. I=E2=80=99d lik= e to >> keep that. > > Re-added. > > Let me know if there's anything else, I must I admit that I do not fully understand your approach. Why do you treat keywords and description differently (with description in org-html-meta-tags and keywords in org-html--build-meta-info)? Why do you pass _title into the lambda expressions in org-html-meta-tags when it is never used? Currently, the variable org-html-meta-tags does not seem user-friendly to me. Also, in org-html--build-meta-info you call org-html-encode-plain-text with two arguments, but it just accepts one. Best wishes Jens