emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: "Christian Köstlin" <christian.koestlin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Ignore flaky ob-python tests
Date: Wed, 02 Nov 2022 06:53:08 +0000	[thread overview]
Message-ID: <878rktluej.fsf@localhost> (raw)
In-Reply-To: <CAG741+b=y2ae8T+7zqO2a35Mn7A2R9pRf4t+bxuhuB0HzLGFDA@mail.gmail.com>

Christian Köstlin <christian.koestlin@gmail.com> writes:

> The new async feature of python seems to be implemented in a way
> that can break with high CPU load. This patch still runs the 3 tests in
> question, but does not fail the complete testsuite if any of those fail.

Thanks for the patch, but I'm afraid that it will drive the tests useless.
After the patch, even if the tests fail for a valid reason, it will not
be visible upon running make test, AFAIU.

Maybe we can instead provide some variable that can turn-on ignoring
some problematic tests only during CI tests?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-11-02  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  0:41 [PATCH] Ignore flaky ob-python tests Christian Köstlin
2022-11-02  6:53 ` Ihor Radchenko [this message]
2022-11-02 11:15   ` Christian Köstlin
2022-11-02 13:55     ` Jack Kamm
2022-11-02 14:12       ` Ihor Radchenko
2022-11-02 14:17         ` Ihor Radchenko
2022-11-03  7:14     ` Ihor Radchenko
2022-11-03 21:15       ` Christian Köstlin
2022-11-04  4:19         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rktluej.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=christian.koestlin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).