emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Daniel Kraus <daniel@kraus.my>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Andreas Gerler <baron@bundesbrandschatzamt.de>, emacs-orgmode@gnu.org
Subject: Re: [BUG] ob-sql sql-connection-alist
Date: Mon, 16 Jan 2023 11:45:58 +0100	[thread overview]
Message-ID: <878ri2bvsh.fsf@kraus.my> (raw)
In-Reply-To: <87r0vuzs3w.fsf@localhost>


Ihor Radchenko <yantar92@posteo.net> writes:

> Andreas Gerler <baron@bundesbrandschatzamt.de> writes:

>> (setq sql-connection-alist
>>       '((testdb (sql-product 'mysql)
>>                 (sql-server "127.0.0.1")
>>                 (sql-user "mysql”)
>>                 (sql-port 3306)
>>                 (sql-password “foo")
>>                 (sql-database "mysql"))))
>
> I am looking at the docstring of `sql-connection-alist':
>
>     An alist of connection parameters for interacting with a SQL product.
>      Each element of the alist is as follows:
>
>        (CONNECTION \(SQL-VARIABLE VALUE) ...)
>
>      Where CONNECTION is a case-insensitive string identifying the
>      connection, ...
>
> So, your "setq" example is incorrect: must use "testdb" instead of
> `testdb' symbol.

I'm not sure why but I also have the connection as a symbol in my
`sql-connection-alist`.
Looking in `sql.el` `(sql-connect)`, they also use
`assoc-string` to receive the connection:
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?h=ac2a6fc83fac6390892b068a830ebe0f22364e05#n4398

So I think that change is good and supports both formats
(same as `sql-connect`).

Cheers,
  Daniel


  reply	other threads:[~2023-01-16 10:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 16:00 [BUG] ob-sql sql-connection-alist Andreas Gerler
2023-01-16 10:25 ` Daniel Kraus
2023-01-20 17:24   ` Andreas Gerler
2023-01-20 17:30     ` Andreas Gerler
2023-01-20 20:41       ` Daniel Kraus
2023-01-20 21:03         ` Andreas Gerler
2023-01-21  8:48         ` Ihor Radchenko
2023-01-21 12:15           ` Andreas Gerler
2023-01-22 10:58           ` Bastien Guerry
2023-01-26 10:44           ` Bastien Guerry
2023-01-27 13:13             ` Ihor Radchenko
2023-01-27 13:18             ` Ihor Radchenko
2023-01-27 16:58               ` Andreas Gerler
2023-01-28 14:13                 ` Andreas Gerler
2023-01-30 16:59                   ` Daniel Kraus
2023-01-16 10:33 ` Ihor Radchenko
2023-01-16 10:45   ` Daniel Kraus [this message]
2023-01-16 11:05     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ri2bvsh.fsf@kraus.my \
    --to=daniel@kraus.my \
    --cc=baron@bundesbrandschatzamt.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).