From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CEn4CyM9HGSxOQEASxT56A (envelope-from ) for ; Thu, 23 Mar 2023 12:50:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QLyJCyM9HGR60QAAauVa8A (envelope-from ) for ; Thu, 23 Mar 2023 12:50:59 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8ADD9CFB for ; Thu, 23 Mar 2023 12:50:58 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfJSS-0005Wk-Ik; Thu, 23 Mar 2023 07:50:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfJSQ-0005WU-Tg for emacs-orgmode@gnu.org; Thu, 23 Mar 2023 07:50:14 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfJSO-0002tW-SQ for emacs-orgmode@gnu.org; Thu, 23 Mar 2023 07:50:14 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4DAD42406F0 for ; Thu, 23 Mar 2023 12:50:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679572210; bh=dkSxf8va+6acbp3Gr+Q02zAAW0Zb1lr82Dhnu4Lismc=; h=From:To:Cc:Subject:Date:From; b=h8TD9/qksVbrySbyX2ZJA4BxYRA0j3V7/S9MlwFQ2qWvXM7NWFn2y6KJXrrvildHJ tRZmQuyaEJUVUomcC+qQhVD+F9Tvedbzi3E7tqqyw9lByxbz4bwBU0g2vVOjhgTpp+ gmb8G314srobcC8oWkECNNl6Kyl+cFwdShdvBQAtv52pqIY9Q4PJy+vmNopGWTEXD9 l7/LWrvXomkoMfEdzwZq2CTMbR39M+vXy2yvKO+y807Cc2zzLPejFbg/8iKe6GToGX /p5Vgs1agpN2DWzv8sTCUVfHyVpdwMcTtwfJD6uHFCF/yneXM6P6L3MJbF4KndeVcu R9jVlT6ijgUrw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pj3YY3vvfz6tnM; Thu, 23 Mar 2023 12:50:09 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: emacs-orgmode@gnu.org Subject: Re: [patch] ob-clojure: Fix results output In-Reply-To: <87mt43em3k.fsf@kraus.my> References: <87mt4m53qj.fsf@kraus.my> <87pm9gyebl.fsf@localhost> <877cvkhh9d.fsf@kraus.my> <874jqno6hw.fsf@localhost> <873567h2kk.fsf@kraus.my> <87y1nzflur.fsf@kraus.my> <87v8j2qpsq.fsf@localhost> <87ttymfe9i.fsf@kraus.my> <87y1nxt2v2.fsf@localhost> <87edplyxj5.fsf@localhost> <87zg88eaib.fsf@kraus.my> <877cv9oye2.fsf@localhost> <87mt43em3k.fsf@kraus.my> Date: Thu, 23 Mar 2023 11:52:05 +0000 Message-ID: <878rfnn0re.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679572259; a=rsa-sha256; cv=none; b=gVSQlvNelXYto2RNeqMihjZEaWu8rumGWpLbloJ5Z5Rn08ZYaj3OEgkCZibXlYhpa99Rpa qvUam21/M1qomp5ikedpRohvB4aphJ/n/2g3lWH0Nv0TCvUxFnfp9bPCrxxMrT2rIcbrn+ WJsOV7K4RlaUGs/VNpmNNb/PdC/0CVBM2jVAR4y4nTmGTI/9nJEE7YVqZbndbr8Wbaw/IX PojcOZcdwAXKg9TbIUpjySKPfIwChQfezHmEkKpUPAAFEJ3JTA7ifgf8y/JWc6u8rTYV76 mTICYaAYvL1prXRDB48b+k/ZMgixjuSirKDJ4yZ3A9W/ISHm9Mcs4eoJWbiwTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="h8TD9/qk"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679572259; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k29pC6knavO5nRco8TwNNPGxNZpCfyAYyfkbl6fKUYA=; b=oJa5pUJSkHDk1DjxwY5dPjm1N7oIk+8XrXhfmY1Qp239rvHfEnziA2kb3QPx3Zq0OvZP/n bCmyL0TSetiqg6M0VSr87GcdNk5H6e5HAGFxPgNRY/Aw8xnlhPx7fsoYaX+j5GWTdKsWzG ukqtMlVcqqAySKWKK/GZkgu9xFFn4G61ACGVtjEMnde62XR1BlbI3ApJM6jmdjSiAzWER9 ukKOuYqb5yvO9nTLNdr5MA8zxDRzn78wZCnlESZWKxLWu5phaNR/kaJ1SU9YbK7zvOzj8j 2R8QRVz7vGgdsJVCJLUjEGxrwr7NJxeGpIzayCzGyE7kz7uOvqM4eS9NhXTmqA== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="h8TD9/qk"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.76 X-Spam-Score: -4.76 X-Migadu-Queue-Id: E8ADD9CFB X-TUID: DQk5aLkaSWWK Daniel Kraus writes: > Ihor Radchenko writes: > >> Now, the docstring appears to be a bit confusing: >> >> (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p) >> "Evaluate EXPANDED code block with PARAMS using cider. >> When CLJS-P is non-nil, use a cljs connection instead of clj." >> >> It would be useful to mention that PARAMS argument is unused. > > Should I go with your initial suggestion and just replace it with _? > Like > > (defun ob-clojure-eval-with-cider (expanded _ &optional cljs-p) > "Evaluate EXPANDED code block using cider. > When CLJS-P is non-nil, use a cljs connection instead of clj." > > But then someone will maybe wonder why there is unused argument? > > Or rather something like: > > (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p) > "Evaluate EXPANDED code block using cider. > When CLJS-P is non-nil, use a cljs connection instead of clj. > The PARAMS from Babel are not used in this function." I like the second variant better. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at