From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sKCJAspe7GSQOQEA9RJhRA:P1 (envelope-from ) for ; Mon, 28 Aug 2023 10:46:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sKCJAspe7GSQOQEA9RJhRA (envelope-from ) for ; Mon, 28 Aug 2023 10:46:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F3FE4A2ED for ; Mon, 28 Aug 2023 10:46:01 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=k1XM0HiS; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693212361; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=WM8wX4G6NVdWyJp6Ozjwo/de+8sagQUFWsioQXc+TN8=; b=pp4CbJcHTuDpW/a1pf4+88YYbrLn5krTOEpph33erlLsrUrPidn11gWKW5FBcUmOZ/9JF7 jikAN9fzV3hV4Mmk7ZgutlzvfprqYbBSKZSZRGZm0C1PMzXGHI4iBwGu5EmmlH7t6M/lx4 zGgBvdCP0sEAcMWRr09zSlABJ/Yi4OKDMmh/chqp9b5pTIb+Vd/X1LtpHHdPlBvhh69DhE an+6uOK+OsO519CuhNM4wXqOw/LSz3HhpuPScjg5W+ixw210RCc2TPXm7PhagTUhZFfzV+ SPXDgjPVa9AtMSUj0H2KnDQniAuTd6zbsgYuHWvPs8r/tR6LGv2Fv87I34zL8g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693212361; a=rsa-sha256; cv=none; b=AjGhkfWzZkiFfzvJbLJCcnh1iJAg72VFDyw8vtPxfCobUxBO5tdEtZRyzMaVz7ayYl+0Yk nIYkYI5WAkD9S6mOaYjRuIn+V6Y69vwJLmwPbQbsdqFohs6TkRiBkTQCqqiw/zfruhvM5d VD/HdaWLze3G5xksLKfcELvoSb7kBtHbzqaReCVQ7liuB+HuPCi3m/UcjtW1ECLBxEMKAZ 0Q3JovQ2N9XxomE+1WkuAX8oOZ4p3WVPIpjdgNHtrSHm/konUGlzMaWApRP6k7yXGjkinr Bd88/DdvYFcyY5MzHOvHmnfXenMsy8ahGtPnfjsUyCVZY/n0CMhiiVwnXqOS3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=k1XM0HiS; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaXrv-0005bn-MR; Mon, 28 Aug 2023 04:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaXrs-0005Zw-8L for emacs-orgmode@gnu.org; Mon, 28 Aug 2023 04:45:06 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaXrn-0007zq-T1 for emacs-orgmode@gnu.org; Mon, 28 Aug 2023 04:45:02 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6C216240104 for ; Mon, 28 Aug 2023 10:44:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693212297; bh=O950N96zf7AGbavbEcmSAh5f9mSQiG/DT6ydUKw6OsI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=k1XM0HiS5fC+DiW4+/TNab/SwfG6sY377MdUcMsq+BzTpk4sexPb/3f9GwJuSqo+T 2j7ZeFNcsmb5EZgd/zSEHDzNg7a0htIGjoeOxC/wEXugGNbn5yjzaaNHAezdIvPSjv 90V+1T7AqSN51CyxYuGDrlnOy6lGxlPXYjvRKVcmpoDleGQ/lhInoEH/1vOaBQHBYR couSxloSxohT7Z769nVFAV2VnGHv3CC2+jka8Q9uz24ig+bk8VjBZ9z1elnzlBX1b5 nghwnk3KzR8lCZKrDm/YvlFeypwTQYJSfbDroRFqfdM+GpK6aXPnaeIS8Ts/b3/a2x uoz9xvhY6d9aQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RZ3yw6FGvz6vZV; Mon, 28 Aug 2023 10:44:56 +0200 (CEST) From: Ihor Radchenko To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix a possibly problematic string comparison In-Reply-To: <20230827214320.46754-1-salutis@me.com> References: <20230827214320.46754-1-salutis@me.com> Date: Mon, 28 Aug 2023 08:45:27 +0000 Message-ID: <878r9v4kt4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.97 X-Spam-Score: -6.97 X-Migadu-Queue-Id: 9F3FE4A2ED X-Migadu-Scanner: mx1.migadu.com X-TUID: 7gZuvvfFWpRt Rudolf Adamkovi=C4=8D writes: > * lisp/org-table.el (org-table-make-reference): Replace 'eq' with > 'string-empty-p' to resolve "Warning: 'eq' called with literal string > that may never match" issued on every 'make' invocation. > > - (if (and (eq elements "") (not keep-empty)) > + (if (and (string-empty-p elements) (not keep-empty)) This is not as trivial. Applying this patch will break tests. One needs to carefully examine the org-table logic to fix this particular warning. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at