[BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Hello,

org-link-preview-file emits "Your Emacs does not support displaying images! "
when restoring buffers with desktop when Emacs was started as daemon.

Steps to reproduce.
1. Start Emacs with --daemon or --fg-daemon
2. Enable desktop
3. Have org-mode buffers containing image previews
4. Restart Emacs
5. Error.

The message false or at least confusing.


Emacs  : GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2)
Package: Org mode version 9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)


Regards,

Björn

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

Thanks for the bug report.

> org-link-preview-file emits "Your Emacs does not support displaying images! "
> when restoring buffers with desktop when Emacs was started as daemon.

Just checking, do you have

#+startup: imagepreviews

or

#+startup: linkpreviews

in these files?  Or do you call `org-link-preview' or
`org-toggle-inline-images' manually?

Karthik

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Thanks for the bug report.
>
>> org-link-preview-file emits "Your Emacs does not support displaying images! "
>> when restoring buffers with desktop when Emacs was started as daemon.
>
> Just checking, do you have
>
> #+startup: imagepreviews
>
> or
>
> in these files?  Or do you call `org-link-preview' or
> `org-toggle-inline-images' manually?

I have this in my init.el:
;; Show inline images by default
(setopt org-startup-with-inline-images t)

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

>>> org-link-preview-file emits "Your Emacs does not support displaying images! "
>>> when restoring buffers with desktop when Emacs was started as daemon.
>>
>> Just checking, do you have
>>
>> #+startup: imagepreviews
>
> I have this in my init.el:
> ;; Show inline images by default
> (setopt org-startup-with-inline-images t)

Ihor, what would be the best way of handling this?  We can add a
`display-graphic-p' test when running the inline-images part of
org-startup, but then link previews that are not images won't be applied
either.

Karthik

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Ihor, what would be the best way of handling this?  We can add a
> `display-graphic-p' test when running the inline-images part of
> org-startup, but then link previews that are not images won't be applied
> either.

1. As a minimum, we can remove that message and do nothing on
   non-graphical displays. It will be consistent with earlier behavior.

2. Maybe we can move the check about graphics to the specific preview
   functions.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

>> Ihor, what would be the best way of handling this?  We can add a
>> `display-graphic-p' test when running the inline-images part of
>> org-startup, but then link previews that are not images won't be applied
>> either.
>
> 1. As a minimum, we can remove that message and do nothing on
>    non-graphical displays. It will be consistent with earlier behavior.

I will remove that message from org-link-preview-file.

> 2. Maybe we can move the check about graphics to the specific preview
>    functions.

What do you mean by 2?  The check about graphics is already a part of
org-link-preview-file, which is a specific preview function.

Karthik

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

>> 1. As a minimum, we can remove that message and do nothing on
>>    non-graphical displays. It will be consistent with earlier behavior.
>
> I will remove that message from org-link-preview-file.

+1

>> 2. Maybe we can move the check about graphics to the specific preview
>>    functions.
>
> What do you mean by 2?  The check about graphics is already a part of
> org-link-preview-file, which is a specific preview function.

Right. No idea why I wrote that.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

>>> 1. As a minimum, we can remove that message and do nothing on
>>>    non-graphical displays. It will be consistent with earlier behavior.
>>
>> I will remove that message from org-link-preview-file.
>
> +1

Patch attached.

Karthik

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ol-No-message-when-previewing-images-in-non-graphica.patch --]
[-- Type: text/x-patch, Size: 1143 bytes --]

From 621396f4b5c46f109aaec5afcb0a983153d8a60a Mon Sep 17 00:00:00 2001
From: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Date: Fri, 27 Dec 2024 19:45:01 -0800
Subject: [PATCH] ol: No message when previewing images in non-graphical
 context

* lisp/ol.el (org-link-preview-file): Don't message the user when
attempting to preview links as images in an environment that
doesn't support graphics.  This includes the case when
`org-link-preview' runs in the Emacs daemon with no frames open.
---
 lisp/ol.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/ol.el b/lisp/ol.el
index 9e2459cde..c21869fbc 100644
--- a/lisp/ol.el
+++ b/lisp/ol.el
@@ -2178,9 +2178,7 @@ (defun org-link-preview-file (ov path link)
 
 This is intended to be used as the `:preview' link property of
 file links, see `org-link-parameters'."
-  (if (not (display-graphic-p))
-      (prog1 nil
-        (message "Your Emacs does not support displaying images!"))
+  (when (display-graphic-p)
     (require 'image)
     (when-let* ((file-full (expand-file-name path))
                 (file (substitute-in-file-name file-full))
-- 
2.47.0

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

>>> I will remove that message from org-link-preview-file.
>>
>> +1
>
> Patch attached.

Thanks!
Applied, onto main, after adding a link to this thread to the commit
message.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ab14970b63

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko <yantar92@posteo.net> writes:

> Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
>
>>>> I will remove that message from org-link-preview-file.
>>>
>>> +1
>>
>> Patch attached.
>
> Thanks!
> Applied, onto main, after adding a link to this thread to the commit
> message.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ab14970b63

Can preview be generated without a frame be open, so that when the user
visits the file after the first frame has been opened it is there.

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar <bjorn.bidar@thaodan.de> writes:

> Can preview be generated without a frame be open, so that when the user
> visits the file after the first frame has been opened it is there.

Do you mean asking whether Emacs can generate graphics when running as
daemon? AFAIK, no. All the graphics-related facilities cannot work until
at least one Emacs frame is created.

I am not sure if it is a technical limitation or just a mere
omission. You may consider asking on emacs-devel.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>