Bug: `org-edit-special` doesn't respect dedicated windows

Bug: `org-edit-special` doesn't respect dedicated windows

[Alexis]

Context:

Manually compiled Emacs 24.4.1 on Debian Wheezy(+updates) x86_64.

ECM:

1. emacs -Q
2. Split frame into two windows via `C-x 3`.
3. Make one "*scratch*" buffer window dedicated via:
   (a) `M-:`
   (b) (set-window-dedicated-p (selected-window) t)
4. Select the other window.
5. Visit file `test.org`, containing:

    * Test
    #+begin_src emacs-lisp
      (message "Test.")
    #+end_src

6. Move point within source block, do `org-edit-special`.
7. The "*scratch*" buffer window will have its contents changed to 
   contain an Org buffer.


Alexis.

Re: Bug: `org-edit-special` doesn't respect dedicated windows

[Nicolas Goaziou]

Hello,

Alexis <flexibeast@gmail.com> writes:

> ECM:
>
> 1. emacs -Q
> 2. Split frame into two windows via `C-x 3`.
> 3. Make one "*scratch*" buffer window dedicated via:
>    (a) `M-:`
>    (b) (set-window-dedicated-p (selected-window) t)
> 4. Select the other window.
> 5. Visit file `test.org`, containing:
>
>     * Test
>     #+begin_src emacs-lisp
>       (message "Test.")
>     #+end_src
>
> 6. Move point within source block, do `org-edit-special`.
> 7. The "*scratch*" buffer window will have its contents changed to 
>    contain an Org buffer.

Org uses `org-src-window-setup' to control the display, which overrides
dedicated windows. You may want to customize the former.


Regards,

-- 
Nicolas Goaziou

Re: Bug: `org-edit-special` doesn't respect dedicated windows

[Alexis]

On 2015-03-01T20:20:06+1100, Nicolas Goaziou said:

 NG> Org uses `org-src-window-setup' to control the display, which 
 NG> overrides dedicated windows. You may want to customize the 
 former.

Thanks for bringing my attention to this variable! However, 
setting it to 'current-window seems to have no effect; rather than 
the Org buffer being replaced by an Emacs Lisp buffer, either a 
new window is created for the latter, or an existing 
(non-dedicated) window is taken over by the latter. Am i missing 
something / doing something else wrong?

(Btw, i'm using version 20150223 of Org from the orgmode.org ELPA 
- sorry i didn't mention that in my previous message!)


Alexis.

Setting `org-src-window-setup` has no effect? [was: Re: Bug: `org-edit-special` doesn't respect dedicated windows]

[Alexis]

Ping? 

On 2015-03-01T20:31:33+1100, Alexis <flexibeast@gmail.com> said:

 A> On 2015-03-01T20:20:06+1100, Nicolas Goaziou said: NG> Org 
 uses `org-src-window-setup' to control the display, which NG> 
 overrides dedicated windows. You may want to customize the A> 
 former.

 A> Thanks for bringing my attention to this variable! However, A> 
 setting it to 'current-window seems to have no effect; rather 
 than A> the Org buffer being replaced by an Emacs Lisp buffer, 
 either a A> new window is created for the latter, or an existing 
 A> (non-dedicated) window is taken over by the latter. Am i 
 missing A> something / doing something else wrong?

 A> (Btw, i'm using version 20150223 of Org from the orgmode.org 
 ELPA A> - sorry i didn't mention that in my previous message!)


 A> Alexis.

Re: Bug: `org-edit-special` doesn't respect dedicated windows

[Nicolas Goaziou]

Alexis <flexibeast@gmail.com> writes:

> Thanks for bringing my attention to this variable! However, setting it
> to 'current-window seems to have no effect; rather than the Org buffer
> being replaced by an Emacs Lisp buffer, either a new window is created
> for the latter, or an existing (non-dedicated) window is taken over by
> the latter. Am i missing something / doing something else wrong?
>
> (Btw, i'm using version 20150223 of Org from the orgmode.org ELPA -
> sorry i didn't mention that in my previous message!)

I cannot reproduce the problem with `current-window' on development
branch.

Regards,

Re: Bug: `org-edit-special` doesn't respect dedicated windows

[Alexis]

On 2015-03-08T07:34:36+1100, Nicolas Goaziou 
<mail@nicolasgoaziou.fr> said:

 NG> Alexis <flexibeast@gmail.com> writes:

 >> Thanks for bringing my attention to this variable! However, 
 >> setting it to 'current-window seems to have no effect; rather 
 >> than the Org buffer being replaced by an Emacs Lisp buffer, 
 >> either a new window is created for the latter, or an existing 
 >> (non-dedicated) window is taken over by the latter. Am i 
 >> missing something / doing something else wrong?
 >> 
 >> (Btw, i'm using version 20150223 of Org from the orgmode.org 
 >> ELPA - sorry i didn't mention that in my previous message!)

 NG> I cannot reproduce the problem with `current-window' on NG> 
 development branch.

Okay, it turns out that the problem was the 
`display-buffer-function` variable being set elsewhere, which 
prevented `org-src-window-setup` from working correctly. Sorry for 
the hassle.


Alexis.