emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: marc@ihm.name
Cc: emacs-orgmode@gnu.org, vicentemvp@gmail.com
Subject: Re: Error when using org-ctrl-c-ctrl-c to add tags
Date: Mon, 20 Apr 2015 10:19:43 +0200	[thread overview]
Message-ID: <877ft7qkio.fsf@gmx.us> (raw)
In-Reply-To: <xkfpp70f6hy.fsf@ihm.name> (Marc Ihm's message of "Sun, 19 Apr 2015 18:05:45 +0200")

Hi,

Marc Ihm <marc@ihm.name> writes:

> Okay, this one only tries to fix, what seems broken ...
> Could someone please check ?

Please run pull the latest version and create your patch using git am.

I still don't know how to reproduce the error.  I have tried with Emacs
24.4 and the git version.

Combining your two diffs I get:

diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,11 +10512,11 @@ from."
                  (listp (second args)))
             'org-iswitchb-completing-read)
            (t (or (and (boundp 'completing-read-function)
-                       completing-read-function)
-                  'completing-read)))
+                       completing-read-function))
+              'completing-read))
       (concat (car args))

which seems wrong (notice that the or becomes irrelevant).

What is completing-read-function?

Thanks,
Rasmus

-- 
You people at the NSA are becoming my new best friends!

  parent reply	other threads:[~2015-04-20  8:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 18:50 Error when using org-ctrl-c-ctrl-c to add tags Vicente Vera
2015-04-19 14:36 ` Marc Ihm
2015-04-19 14:53   ` Rasmus
2015-04-19 15:03   ` Vicente Vera
2015-04-19 16:05   ` Marc Ihm
2015-04-20  2:06     ` Vicente Vera
2015-04-20  8:19     ` Rasmus [this message]
2015-04-20 12:20       ` Rasmus
2015-04-20 20:02         ` Marc Ihm
2015-04-26 21:59           ` Ken Mankoff
2015-04-27  8:26             ` Rasmus
2015-04-27 12:32               ` Ken Mankoff
  -- strict thread matches above, loose matches on Subject: below --
2015-04-18  2:05 Vicente Vera
2015-04-18 17:08 ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ft7qkio.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    --cc=marc@ihm.name \
    --cc=vicentemvp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).