Re: Changes to contrib

[Kosyrev Serge <_deepfire@feelingofgreen.ru>]

Hi,

Rasmus <rasmus@gmx.us> writes:
> Kosyrev Serge <_deepfire@feelingofgreen.ru> writes:
>> The question is.. the only documentation for ox-taskjuggler that exists
>> in Worg, seems to only cover the surface aspects of export -- none of
>> the existing documentation touches on the multitude of details that the
>> existing code does involve itself with.
>
> OK.  There should be docstring and potentially comments, if necessary.
> Worg is a separate issue.

OK, will do.

>>> You use string-join, which is in subr-x.  I think subr-x was not a
>>> dependency before.
>>
>> Oh, indeed -- missed that!
>>
>> What should I do about it?
>
> I’d just use mapconcat TBH, since it’s just one place as I recall.
>
>     (equal (string-join '("a" "b") " ")
>            (mapconcat 'identity '("a" "b") " "))
>
>> Understood, will rename, then.

All done, sending mails..

-- 
с уважениeм / respectfully,
Косырев Сергей