From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SAhOKu4V0GJWiAAAbAwnHQ (envelope-from ) for ; Thu, 14 Jul 2022 15:11:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GP3uKO4V0GLxYQAAG6o9tA (envelope-from ) for ; Thu, 14 Jul 2022 15:11:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5767F88FF for ; Thu, 14 Jul 2022 15:11:09 +0200 (CEST) Received: from localhost ([::1]:53048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBycW-0003sS-Cq for larch@yhetil.org; Thu, 14 Jul 2022 09:11:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oByUv-0000yG-JP for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 09:03:17 -0400 Received: from [2a01:c0:2:6:225:90ff:fed2:2b47] (port=47985 helo=mail.oa5.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oByUr-0003nq-TX for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 09:03:17 -0400 Received: from hugoLaptop (localhost.localdomain [127.0.0.1]) hugo@heagren.com (authenticated bits=0) by mail.oa5.com (8.14.4/8.12.11) with ESMTP id 26ED32at002425 sender hugo@heagren.com ; Thu, 14 Jul 2022 14:03:05 +0100 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=heagren.com; h= Message-ID:From:Subject:Date:To:MIME-Version:Content-Type; s= 202207; bh=v8S/gOFBmUWlgvylWjMGYSX68X4=; b=OtLqmHh7fUK66VPDKaviu ZTNc+4EG8Qpph445LeMiKu4RHdtsleVsFUTu6w5L9TVJrludW6RmA0gff9rHYVzA kb/SumLr14wnPGk50H9cfz8vfmCFJqBvTicRCQyGD3PqBB9d/l8kMUfV5+yGRqwX Abh06MvMLUTMwWn+tPgo+A37mBOBRMGOJULtaWSkFjuJR7RY22r7u+ruLyEPV29d 4xSMQhCGRgGvEZR2/tUyZ0tW72aCOtNbe+/6yexJByd X-Assp-Version: 2.6.7(22137) on ASSP.OA5.COM X-Assp-ID: ASSP.OA5.COM X-Assp-Session: 7FD22141B0C8 (mail 1) X-Assp-Envelope-From: hugo@heagren.com X-Assp-Intended-For: emacs-orgmode@gnu.org X-Assp-Intended-For: yantar92@gmail.com X-Assp-Client-TLS: yes Received: from global-5-153.nat-2.net.cam.ac.uk ([131.111.5.153] helo=hugoLaptop) by ASSP.OA5.COM with SMTPSA(TLSv1_2 ECDHE-RSA-AES128-GCM-SHA256) (2.6.7); 14 Jul 2022 14:03:02 +0100 From: Hugo Heagren To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> <871qvixhfw.fsf@gmail.com> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> Date: Thu, 14 Jul 2022 14:08:34 +0100 Message-ID: <877d4flu3x.fsf@heagren.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:c0:2:6:225:90ff:fed2:2b47 (failed) Received-SPF: pass client-ip=2a01:c0:2:6:225:90ff:fed2:2b47; envelope-from=hugo@heagren.com; helo=mail.oa5.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657804270; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Yhn9efIi8Aick88f3aD2k89k3ZRwQ8nJSJNTue6eOs4=; b=geXqiJgBWJXtWLHnyRsR/zcjLrTKtL7/n36k4mInjhPuvA44Ak6IkulBA35gq0ERlNsaLz 0DGiQAYOFOaf0IAMCeA7Qs3gzFj5MkzRTraiH99m1vSEmFTBUqPdn7KhaA8C5ARbOWB1cN VPleop2ODD+ei5iYnkULpIrBunHmUQHrMP5L2Ce1uaPT83qRjf3CjkdAPsA8ZSUm0H6jP4 cJ53LTEfY0j3xV8zxajQklXSnGZc+te3DT1FBsXDh1cjWbBT8F6T6O0jAUpnrs9lGeC13n Y/3rmjpbsN9RPSUFqB0NqwcPSxiGtxa5tnMXYuiNiTcOGhtbhhlNyGO61VNEfA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657804270; a=rsa-sha256; cv=none; b=As8Ja3RQgpz9jFvqgwt2e2Ar1JfKY9R2Bovks6uhuQv7lOFLEaFiucY8PQYWyxm3Kfb7nN xCS2UOhNfoyrFZh2dD1NI8Fs9W+N0KGolojfa+xPwrDcKIR52POh9vSV/bsKAV7h4GwZuW saOE6DHUVY0izkXV+LOyetDMbbA8ceMGtTB7jJinru8PAvdAV4ISXV6e9ys8jxkMLmTvFr cfjWfCE67I13uMNYa4bmq3SK29KeidJc0j2yU8QKwNc2RoiVsKayZp7B1Wlje1daM60IhC mYB2BEfqhKFba2GcWfQWI1uoiq95XqHTUggcHGd9fbjUNQeHu4McxGz8qnHCJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=heagren.com header.s=202207 header.b=OtLqmHh7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=heagren.com (policy=quarantine); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.00 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=heagren.com header.s=202207 header.b=OtLqmHh7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=heagren.com (policy=quarantine); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5767F88FF X-Spam-Score: 6.00 X-Migadu-Spam: Yes X-Migadu-Scanner: scn0.migadu.com X-TUID: TMEpmb4cFrvA --=-=-= Content-Type: text/plain Content-Disposition: inline Ihor Radchenko writes: > Currently, the internal implementation will treat nil return value as if > there was no :default-description and org-link-make-description-function > were set to nil. We may probably document this. It sounds like a useful > behavior. I added some relevant documentation to the `:default-description' part of the `org-link-parameters' docstring. I also changed the previosly-failing test to expect the right value. All the tests pass now. > Could you also add the proper changelog entry for the test-ol.el > file? Think I've got this right now, and other formatting errors. > unwind-protect is more suitable here and will lead to more concise > code. I didn't know about `unwind-protect', thanks! You're right, much better. > I think that we should also document the new parameter in ORG-NEWS. Done. Thanks, Hugo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ol.el-add-description-format-parameter-to-org-link-p.patch >From cd5268bc05324140a4cf384ce12b99bba1ddab47 Mon Sep 17 00:00:00 2001 From: Hugo Heagren Date: Mon, 28 Mar 2022 23:18:45 +0100 Subject: [PATCH] ol.el: add description format parameter to org-link-parameters * ol.el (org-link-parameters): Add parameter `:default-description', a string or a function. * (org-insert-link): If no description is provided (pre-existing or as an argument), next option is to use the `:default-description' (if non-nil) parameter to generate one. Default descriptions are predictable within a link type, but because link types are quite diverse, are NOT predictable across many types. A type-parameter is thus a good place to store information on the default description. --- etc/ORG-NEWS | 7 +++++++ lisp/ol.el | 56 +++++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 52 insertions(+), 11 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 35af94f92..d51899b20 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -322,6 +322,13 @@ purpose of the variable. The replacement variable accepts =listings= and =verbatim= in place of =t= and =nil= (which still work, but are no longer listed as valid options). +*** ~org-link-parameters~ has a new ~:default-description~ parameter + +The value of ~:default-description~ is used as the initial input when +prompting for a link description. It can be a string (used as-is) or +a function (called with the same arguments as +~org-make-link-description-function~ to return a string to use). + * Version 9.5 ** Important announcements and breaking changes diff --git a/lisp/ol.el b/lisp/ol.el index d4bd0e40c..e568cd6fc 100644 --- a/lisp/ol.el +++ b/lisp/ol.el @@ -141,6 +141,18 @@ link. Function that inserts a link with completion. The function takes one optional prefix argument. +`:default-description' + + String or function used as a default when prompting users for a + link's description. A string is used as-is, a function is + called with two arguments: the full link text, and the + description generated by `org-insert-link'. It should return + the description to use (this reflects the behaviour of + `org-link-make-description-function'). If it returns nil, no + default description is used, but no error is thrown (from the + user's perspective, this is equivalent to a default description + of \"\"). + `:display' Value for `invisible' text property on the hidden parts of the @@ -1804,11 +1816,14 @@ prefix negates `org-link-keep-stored-after-insertion'. If the LINK-LOCATION parameter is non-nil, this value will be used as the link location instead of reading one interactively. -If the DESCRIPTION parameter is non-nil, this value will be used as the -default description. Otherwise, if `org-link-make-description-function' -is non-nil, this function will be called with the link target, and the -result will be the default link description. When called non-interactively, -don't allow to edit the default description." +If the DESCRIPTION parameter is non-nil, this value will be used +as the default description. If not, and the chosen link type has +a non-nil `:default-description' parameter, that is used to +generate a description as described in `org-link-parameters' +docstring. Otherwise, if `org-link-make-description-function' is +non-nil, this function will be called with the link target, and +the result will be the default link description. When called +non-interactively, don't allow to edit the default description." (interactive "P") (let* ((wcf (current-window-configuration)) (origbuf (current-buffer)) @@ -1818,7 +1833,10 @@ don't allow to edit the default description." (desc region) (link link-location) (abbrevs org-link-abbrev-alist-local) - entry all-prefixes auto-desc) + (all-prefixes (append (mapcar #'car abbrevs) + (mapcar #'car org-link-abbrev-alist) + (org-link-types))) + entry auto-desc type) (cond (link-location) ; specified by arg, just use it. ((org-in-regexp org-link-bracket-re 1) @@ -1859,9 +1877,6 @@ Use TAB to complete link prefixes, then RET for type-specific completion support (unless (pos-visible-in-window-p (point-max)) (org-fit-window-to-buffer)) (and (window-live-p cw) (select-window cw)))) - (setq all-prefixes (append (mapcar #'car abbrevs) - (mapcar #'car org-link-abbrev-alist) - (org-link-types))) (unwind-protect ;; Fake a link history, containing the stored links. (let ((org-link--history @@ -1893,6 +1908,13 @@ Use TAB to complete link prefixes, then RET for type-specific completion support (or entry (push link org-link--insert-history)) (setq desc (or desc (nth 1 entry))))) + (setq type + (cond + ((string-match (rx-to-string `(: string-start (submatch (or ,@all-prefixes)) ":")) link) + (match-string 1 link)) + ((file-name-absolute-p link) "file") + ((string-match "\\`\\.\\.?/" link) "file"))) + (when (funcall (if (equal complete-file '(64)) 'not 'identity) (not org-link-keep-stored-after-insertion)) (setq org-stored-links (delq (assoc link org-stored-links) @@ -1961,12 +1983,24 @@ Use TAB to complete link prefixes, then RET for type-specific completion support (let ((initial-input (cond (description) - ((not org-link-make-description-function) desc) + (desc) + ((org-link-get-parameter type :default-description) + (let ((def (org-link-get-parameter type :default-description))) + (condition-case nil + (cond + ((stringp def) def) + ((functionp def) + (funcall def link desc))) + (error + (message "Can't get link description from org link parameter `:default-description': %S" + def) + (sit-for 2) + nil)))) (t (condition-case nil (funcall org-link-make-description-function link desc) (error (message "Can't get link description from %S" - (symbol-name org-link-make-description-function)) + org-link-make-description-function) (sit-for 2) nil)))))) (setq desc (if (called-interactively-p 'any) -- 2.20.1 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-test-ol-tests-for-default-description-param-when-ins.patch >From 16f4ba5ccb73d09cf9c61eeb67f1ce21c367c043 Mon Sep 17 00:00:00 2001 From: Hugo Heagren Date: Tue, 21 Jun 2022 12:45:50 +0100 Subject: [PATCH] test-ol: tests for default-description param when inserting links * test-ol (test-ol-with-link-parameters-as): Convenience macro for testing. (test-ol-insert-link-get-desc): Convenience macro for testing. (test-ol/return-foobar): Convenience function for testing. (test-ol/insert-link-default-description): Test for various values of `:default-description' in `org-link-parameters' (including `test-ol/return-foobar'). --- testing/lisp/test-ol.el | 85 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/testing/lisp/test-ol.el b/testing/lisp/test-ol.el index 429bb52ee..a5bf5758f 100644 --- a/testing/lisp/test-ol.el +++ b/testing/lisp/test-ol.el @@ -19,6 +19,8 @@ ;;; Code: +(require 'cl-lib) + ;;; Decode and Encode Links @@ -625,5 +627,88 @@ See https://github.com/yantar92/org/issues/4." (test-ol-parse-link-in-text "The http://foo.com/(something)?after=parens link")))) +;;; Insert Links + +(defmacro test-ol-with-link-parameters-as (type parameters &rest body) + "Pass TYPE/PARAMETERS to `org-link-parameters' and execute BODY. + +Save the original value of `org-link-parameters', execute +`org-link-set-parameters' with the relevant args, execute BODY +and restore `org-link-parameters'. + +TYPE is as in `org-link-set-parameters'. PARAMETERS is a plist to +be passed to `org-link-set-parameters'." + (let (orig-parameters) + ;; Copy all keys in `parameters' and their original values to + ;; `orig-parameters'. + (cl-loop for param in parameters by 'cddr + do (setq orig-parameters + (plist-put orig-parameters param (org-link-get-parameter type param)))) + `(unwind-protect + ;; Set `parameters' values and execute body. + (progn (org-link-set-parameters ,type ,@parameters) ,@body) + ;; Restore original values. + (apply 'org-link-set-parameters ,type ',orig-parameters)))) + +(defun test-ol-insert-link-get-desc (&optional link-location description) + "Insert link in temp buffer, return description. + +LINK-LOCATION and DESCRIPTION are passed to +`org-insert-link' (COMPLETE-FILE is always nil)." + (org-test-with-temp-text "" + (org-insert-link nil link-location description) + (save-match-data + (when (and + (org-in-regexp org-link-bracket-re 1) + (match-end 2)) + (match-string-no-properties 2))))) + +(defun test-ol/return-foobar (_link-test _desc) + "Return string \"foobar\". + +Take (and ignore) arguments conforming to `:default-description' +API in `org-link-parameters'. Used in test +`test-ol/insert-link-default-description', for the case where +`:default-description' is a function symbol." + "foobar") + +(ert-deftest test-ol/insert-link-default-description () + "Test `:default-description' parameter handling." + ;; String case. + (should + (string= + "foobar" + (test-ol-with-link-parameters-as + "id" (:default-description "foobar") + (test-ol-insert-link-get-desc "id:foo-bar")))) + ;; Lambda case. + (should + (string= + "foobar" + (test-ol-with-link-parameters-as + "id" (:default-description (lambda (_link-test _desc) "foobar")) + (test-ol-insert-link-get-desc "id:foo-bar")))) + ;; Function symbol case. + (should + (string= + "foobar" + (test-ol-with-link-parameters-as + "id" (:default-description #'test-ol/return-foobar) + (test-ol-insert-link-get-desc "id:foo-bar")))) + ;; `:default-description' parameter is defined, but doesn't return a + ;; string. + (should + (null + (test-ol-with-link-parameters-as + "id" (:default-description #'ignore) + (test-ol-insert-link-get-desc "id:foo-bar")))) + ;; Description argument should override `:default-description'. + (should + (string= + "notfoobar" + (test-ol-with-link-parameters-as + "id" (:default-description "foobar") + (test-ol-insert-link-get-desc "id:foo-bar" "notfoobar"))))) + (provide 'test-ol) ;;; test-ol.el ends here -- 2.20.1 --=-=-=--