emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Hanno Perrey <hanno@hoowl.se>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: Improve automatic fast tag selection keys (was: Odd characters in the fast tags selection interface)
Date: Mon, 08 Aug 2022 21:24:12 +0800	[thread overview]
Message-ID: <877d3izx4z.fsf@localhost> (raw)
In-Reply-To: <87a68g7wnb.fsf@hoowl.se>

Hanno Perrey <hanno@hoowl.se> writes:

> Good point. I attach a patch that does just that. After the '~'
> character, only "space" is assigned -- which feels like a hack, but
> means that the selection key field is empty and that the fields are
> still aligned nicely. Actually selection any of these items is not
> possible as space is assigned to clearing the tags. Should this break
> anything that I have missed in my (brief) tests, please let me know!
>
> Additionally, the range A-Z is used once 'z' is reached before assigning
> non-alphabetic (but reasonably-reachable) characters. In case that
> description is difficult to follow, I attach a screenshot of the
> modified code in action.

Thanks!
Applied onto main via 4db67da68 with minor amendments like adding double
space between sentences and capitalizing first word in sentences.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4db67da68db820184bd9d4208c4f8bd7370ee9de

> Please note that I have not (yet) assigned copyright to the FSF.
> However, I believe that these changes are still trivial enough to
> qualify as TINYCHANGE.

You are good to go until 15LOC total contribution combined.

>> Finally, we may simply not list tags with keys beyond "z" at all only
>> indicating that there are more by showing some text at the end of the
>> menu.
>
> That might be an alternative, as I think not even all tags are shown
> now. Let me know should you rather go down that route instead.

We may, but then we need support from other users. Hiding staff will be
a breaking change, unlike the patch you propose, which barely improves
visuals.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  parent reply	other threads:[~2022-08-08 13:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 21:41 Odd characters in the fast tags selection interface Hanno
2022-08-05  2:12 ` Ihor Radchenko
2022-08-05 10:54   ` Hanno
2022-08-06  8:13     ` Ihor Radchenko
2022-08-07 17:55       ` [PATCH] org.el: Improve automatic fast tag selection keys (was: Odd characters in the fast tags selection interface) Hanno Perrey
2022-08-07 23:42         ` Christopher M. Miles
2022-08-08 13:24         ` Ihor Radchenko [this message]
     [not found]         ` <62f04f7c.d40a0220.9da67.0a2cSMTPIN_ADDED_BROKEN@mx.google.com>
2022-08-08 13:36           ` [PATCH] org-fast-tag-selection: Make group tags separator not break alignment Ihor Radchenko
2022-08-22 12:02             ` Ihor Radchenko
2022-08-07 23:47       ` Odd characters in the fast tags selection interface Christopher M. Miles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d3izx4z.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=hanno@hoowl.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).