From: Ihor Radchenko <yantar92@posteo.net>
To: "Moritz Schäfer" <mail@moritzs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)]
Date: Wed, 19 Oct 2022 10:36:11 +0000 [thread overview]
Message-ID: <877d0wayn8.fsf@localhost> (raw)
In-Reply-To: <CA+FVMQDBUwCQHFOWieELaB3=4MH2ybA66+NpCuQwvvv_1HVMzg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
Moritz Schäfer <mail@moritzs.de> writes:
> Thanks for getting back to me on this.
>
> Here is a minimal example. In org-roam (v2), when having a file/node:
Thanks! An example helps a lot.
Can you try the attached patch against the latest main branch?
[-- Attachment #2: 0001-ox-odt-Allow-id-links-to-files.patch --]
[-- Type: text/x-patch, Size: 1502 bytes --]
From 4e5c7373115cfeb88fb4392252d682fad8d178a8 Mon Sep 17 00:00:00 2001
Message-Id: <4e5c7373115cfeb88fb4392252d682fad8d178a8.1666175750.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Wed, 19 Oct 2022 18:33:44 +0800
Subject: [PATCH] ox-odt: Allow id: links to files
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lisp/ox-odt.el (org-odt-link): Transcode id: links to file property
drawers.
Reported-by: Moritz Schäfer <mail@moritzs.de>
Link: https://orgmode.org/list/CA+FVMQDBUwCQHFOWieELaB3=4MH2ybA66+NpCuQwvvv_1HVMzg@mail.gmail.com
---
lisp/ox-odt.el | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 208a39d9d..4ff667640 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -2737,6 +2737,12 @@ (defun org-odt-link (link desc info)
(format "<text:a xlink:type=\"simple\" xlink:href=\"#%s\">%s</text:a>"
(org-export-get-reference destination info)
(or desc (org-export-get-ordinal destination info))))
+ ;; Link to a file, corresponding to string return value of
+ ;; `org-export-resolve-id-link'.
+ (plain-text
+ (format "<text:a xlink:type=\"simple\" xlink:href=\"%s\">%s</text:a>"
+ destination
+ (or desc (org-export-get-ordinal destination info))))
;; Fuzzy link points to some element (e.g., an inline image,
;; a math formula or a table).
(otherwise
--
2.35.1
[-- Attachment #3: Type: text/plain, Size: 225 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-19 10:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 18:39 [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)] Moritz Schäfer
2022-10-18 7:47 ` Ihor Radchenko
2022-10-19 8:00 ` Moritz Schäfer
2022-10-19 10:36 ` Ihor Radchenko [this message]
2022-10-20 10:09 ` Max Nikulin
2022-10-21 3:16 ` Ihor Radchenko
2022-10-21 14:46 ` Max Nikulin
2022-10-22 5:03 ` [BUG] ox-odt file: links are not pointing to the real files (was: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)]) Ihor Radchenko
2022-10-22 8:04 ` Max Nikulin
2022-10-23 4:29 ` Ihor Radchenko
2022-10-24 11:40 ` Max Nikulin
2022-10-25 10:20 ` Max Nikulin
2022-10-31 6:13 ` Ihor Radchenko
2022-10-31 14:37 ` Max Nikulin
2022-11-01 5:40 ` Ihor Radchenko
2022-11-01 15:04 ` Max Nikulin
2022-11-02 5:04 ` Ihor Radchenko
2022-11-02 15:39 ` Max Nikulin
2022-11-03 6:25 ` [DISCUSSION] Default description for relative file links in odt export (was: [BUG] ox-odt file: links are not pointing to the real files (was: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)])) Ihor Radchenko
2022-11-01 5:47 ` org-export: How to handle links to the exported file? " Ihor Radchenko
2022-11-01 15:18 ` org-export: How to handle links to the exported file? Max Nikulin
2022-11-01 5:48 ` [BUG] ox-odt file: links are not pointing to the real files (was: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)]) Ihor Radchenko
2022-11-01 15:28 ` export and cross links between files Max Nikulin
2022-11-02 6:38 ` [DISCUSSION] Unified handling of links between Org files on export (was: export and cross links between files) Ihor Radchenko
2022-10-21 12:02 ` [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)] Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d0wayn8.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=mail@moritzs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).