From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mNi0KuWO+GMgBwAAbAwnHQ (envelope-from ) for ; Fri, 24 Feb 2023 11:18:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YM++KuWO+GNHeQEA9RJhRA (envelope-from ) for ; Fri, 24 Feb 2023 11:18:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D11489862 for ; Fri, 24 Feb 2023 11:18:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVV8M-0004d2-9A; Fri, 24 Feb 2023 05:16:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVV8I-0004cb-TY for emacs-orgmode@gnu.org; Fri, 24 Feb 2023 05:16:54 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVV8G-0002gL-Sk for emacs-orgmode@gnu.org; Fri, 24 Feb 2023 05:16:54 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1F24C240671 for ; Fri, 24 Feb 2023 11:16:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1677233809; bh=+8lUqluG1xMHxBxOQzqMnLivC0Dqzx1+NOZGwmfFPQI=; h=From:To:Cc:Subject:Date:From; b=ElNUyKuuPZuwZPU/YatdTUZsgmRqCj/4FwmT6epwUI+XCdgxa1UD27p5bleqLBs+R AQNXYk45Afys94nr2h4eMVWxTqNLcqUgJHTjHSW7cdokZ30jcd1EgN7U4CPysatW3C FmTlTnjV5711QSwDe2TIzlq5pTyxWiLqFmp8YmKdtOnQkbuXQ2m44UrZwau3NY8qx7 G4e96e5FZ++uTytNb4XJMs8KZtvFeTj95LT0PpcyicNJ03refgUPjmb+GXNP028hSG V5XTAmraY9YoLEQFEw3+wXSBQXbruJoRs1ZLxouVcV2JGJPXIAGUoK9Oi1vItKDagC J1EEd8As2nIGg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PNQmG3NRNz9rxN; Fri, 24 Feb 2023 11:16:46 +0100 (CET) From: Ihor Radchenko To: Damien Cassou , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure In-Reply-To: <87y1onsfpg.fsf@cassou.me> References: <87cz66278h.fsf@cassou.me> <87y1oqcaif.fsf@localhost> <87y1onsfpg.fsf@cassou.me> Date: Fri, 24 Feb 2023 10:17:26 +0000 Message-ID: <877cw7s6yx.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677233893; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ExM4pp0lHuTpuUKyR9pCHVpG70jz6kCO/oO167IwuEY=; b=uAxkK+wGXb9V4AsQVo8N4vpYWEYRCaqzxshVP1mv3NLmmfrAtPXQY0fXYG5KCVIQpY/Dbw akcNYopCbPXzK/LiqV+cktqmN/TXQkwEBsbtkk0Ge9DGptdyWu8DQogtJwCSYxplwMvMV1 6tJvzPnt+Wm3kRq4rRwI0kOgKpXmu0hwQFffakTywrSEPFDbDLmKrSbVfbQijz+2YOHPU/ zoj8sd6QhaeIaOcnC4TkJk/rFPNJCNAqkdVpBzyOHnLSog7CSGPD8xjYw41aOWgDKdWZaK 53uSKb05Q5ZaWFipGewwmiKSujcHI+lKwFbFOudmd//cEHDZ+wo+AsnraWl7ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ElNUyKuu; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677233893; a=rsa-sha256; cv=none; b=nraQTWmxJbiZD4fC7xISVMGr0hf2VoA38sWdT0CBOK1xIG1SHh+oa3RviB1xzwZ/rjMzKL 9FM6aH9OrFzOzNKwRV+iQSgu9D/0VcW0+IEXtgPxSCQcd85OR2m73/yuBWGAU5+fACn5bJ q7U58pOGEQaR8Ir38Oi+gzsnCiPwWKKKbgi9szAkLT+5TxavC6lGrmwbCq6ghIS3tRJOIg wRu9Ll+/Q9maqZOfWDlJrgoTf1h1Z0pTDwniNJWyoale0/E83bjnOyX+w3/pb9lVXPvwq1 OulitA0+BpW6gChNXkIadraGsLV6Lhx0vfpTZw87Cty58QZJi0d5GDcR+cg65Q== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ElNUyKuu; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.17 X-Spam-Score: -6.17 X-Migadu-Queue-Id: D11489862 X-TUID: C1IC5ZID/Ryf Damien Cassou writes: > I've signed the FSF copyright agreement in the context of my > contributions to Emacs. Do I need to do any more paperwork? No, you don't. Bastien, could you please check FSF records? >> I think that it will be a good idea to indicate in the `message' where >> the error is coming from. The error intercepted by this `condition-case' >> form will likely be a network error, and it may be unclear to the user >> which function is failing to make the connection. > > I tried to make that a little bit clearer: > > (message "Org could't download \"%s\": %s %S" file (car error) (cdr > error)) > > Do you want me to explicitly refer to the current function name? Should be good enough. I think you forgot to attach the updated patch :) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at