From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms9.migadu.com with LMTPS
	id oNSwNOLoSGSOsAAASxT56A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 26 Apr 2023 11:03:30 +0200
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id wB6INOLoSGTIaAEAauVa8A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 26 Apr 2023 11:03:30 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 9C003EB08
	for <larch@yhetil.org>; Wed, 26 Apr 2023 11:03:30 +0200 (CEST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1prb2c-00035u-AY; Wed, 26 Apr 2023 05:02:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1prb2a-00035b-Ou
 for emacs-orgmode@gnu.org; Wed, 26 Apr 2023 05:02:20 -0400
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1prb2M-00024R-U6
 for emacs-orgmode@gnu.org; Wed, 26 Apr 2023 05:02:20 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 85343240376
 for <emacs-orgmode@gnu.org>; Wed, 26 Apr 2023 11:02:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1682499723; bh=AT2NQ3UIGhyCjeihQIIHatpFtjHFgQfCTHsyZj/tAF4=;
 h=From:To:Cc:Subject:Date:From;
 b=RnUuBaD8K86mxs1a6qS8Z9wTtTiU6wNOoAdXDx0Ys7KxfEMq1lLZ/zqbDzeS9oE/p
 KIoDR7LbCkT4vk7RYO8laDSn2O1M1o5ykdxVM5YDHOYrCmCZd3Sgfzyf1S5XxN7pNn
 9hi+6rNfXvF432lhZhRojA13UYekrmUjl7SiPoqJERNi7c1QEQuEIKvE57BT8cqSS9
 6APKZBv8qy3WmLvZyZoS0IUZxVxLUW+kwhJLjoBsvx/e8FXVQzh8FODLKi1o/YCB51
 spXEEgbBJFZ2meO20oQFgtHMHl5326SdAdOjCFt6Zn5s2shZS8++Dg3gc52D10KO00
 D1tZKwXbqjv/Q==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Q5tCv0Jj3z9rxS;
 Wed, 26 Apr 2023 11:02:02 +0200 (CEST)
From: Ihor Radchenko <yantar92@posteo.net>
To: "Ruijie Yu via General discussions about Org-mode." <emacs-orgmode@gnu.org>
Cc: Ruijie Yu <ruijie@netyu.xyz>, Axel Kielhorn <org-mode@axelkielhorn.de>
Subject: Re: [DRAFT PATCH v6] Decouple LANG= and testing (was: Test failure
 due to LANG)
In-Reply-To: <sdvy1mgq920.fsf@netyu.xyz>
References: <D140FA73-9995-4467-963E-00D5964485C0@axelkielhorn.de>
 <sdvzg70utif.fsf@netyu.xyz> <sdvv8housn7.fsf@netyu.xyz>
 <sdvmt30um3h.fsf@netyu.xyz> <sdvedocukz1.fsf@netyu.xyz>
 <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de>
 <sdvy1mkt0vw.fsf@netyu.xyz> <sdvh6t7tlmw.fsf@netyu.xyz>
 <37BA8B13-A49D-41A4-B752-4ED9540D5799@axelkielhorn.de>
 <sdvo7nfrs7p.fsf@netyu.xyz> <871qkau9t6.fsf@localhost>
 <sdvbkjer8c3.fsf@netyu.xyz> <874jp64oxr.fsf@localhost>
 <sdvfs8os6es.fsf@netyu.xyz> <sdvy1mgq920.fsf@netyu.xyz>
Date: Wed, 26 Apr 2023 09:05:01 +0000
Message-ID: <877ctzovya.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net;
 helo=mout01.posteo.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682499810; a=rsa-sha256; cv=none;
	b=grwRiz/CtczoyzR10GxypASJDhkhtSyAEKy07TXVu+N1fO17zl92Yns/BFoNDCXHe+MCOl
	kuVysu4lr+YpxmUfckkflMI+qtmr4BsezDQyoB6CoOWCCxHRkZlf+jHm/T1MbZ9K59vh/Q
	bIcaYjii5CVyngwD9kzt4c0+9JNyUUXSZt8SLhiPROvskKfqgme2CTk2T4mGqxyZRHz5kF
	nUlCvHw6GB8QhR7StEUjHaJv1L/EE6wdO8+neuJ+o3UOX1KPyVusfv9OfbmubRdW0MAzut
	1QO4DMIo7EkRPa7S8vG1mQ4RuyyOy/KM6YuoBvKwACsh/cfzhocJ/kSFvMgzQg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=RnUuBaD8;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1682499810;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=3ZJJqbos1b+xAOHEI3f747Bj6v0Dnj+pzP7SIFKjgVA=;
	b=fbdiwMohxKMQspZ/iSXbSacJFdQxe8JjvzUCEDZSCxhN+mBeUdziV3hajPmzrg1foSvgWQ
	Yl+64NTjuTcHYj/X2sR1qddTyzkkpRtQdpxX1Jfu8GZ0kNBnM2VIZs0oE71Ykqhy2RUtjd
	ggE+IgSytLINCp6LMcIkJRsS9Q9VbUErcPcwtKT7XK4jjCnp6XC363aVzVMDSY48UBszGF
	4D2GmZ1ZfWOo0MBBKaH9wsCJDgG1NJ/mVvoGnE+uoeKobQOhF58XiZV//iBq31upFlpsRO
	jPwe4yn1IV/awcilYDneOEMIbp4+xPhdWgtoClKqsMi6ONszTDbMkPXbIiQx3A==
X-Migadu-Spam-Score: -4.60
X-Spam-Score: -4.60
X-Migadu-Queue-Id: 9C003EB08
X-Migadu-Scanner: scn0.migadu.com
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=RnUuBaD8;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-TUID: Gk3ZCupP+9Zd

Ruijie Yu via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> Iteration v6.  Everything, other than the French test and the
> batch-non-batch Chinese test, now passes.  I'll look up how to determine
> whether we are in batch mode or not, and slap that onto the expect tag
> for `test-org-clock/clocktable/lang'.  And the French test belongs to
> its own thread, so I won't try to fix it here.

Ideally, we should figure out what is behaving differently in batch mode
and report it upstream. Sometimes, these issues are related to our
misunderstandings of how Emacs works. For example, I had to add
`org-current-text-column' because Org relied on some undocumented (and
changed in recent Emacs versions) behaviour of `current-column'.

> From 59cbb93b9fc221bdc8ee708b05943a245c41ad25 Mon Sep 17 00:00:00 2001
> From: Ruijie Yu <ruijie@netyu.xyz>
> Date: Tue, 25 Apr 2023 22:56:02 +0800
> Subject: [PATCH 2/2] Let org-columns correctly detect string-widths in code

I have no comments on the patch. Looks good to me. Better test coverage
will be also welcome.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>