emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Suhail Singh <suhailsingh247@gmail.com>, TEC <orgmode@tec.tecosaur.net>
Cc: Org mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks
Date: Tue, 18 Jun 2024 15:33:43 +0000	[thread overview]
Message-ID: <877cems1t4.fsf@localhost> (raw)
In-Reply-To: <87v8277ye7.fsf@gmail.com>

Suhail Singh <suhailsingh247@gmail.com> writes:

> Unlike example blocks, source code and fixed-width blocks don't support
> the attr_html keyword.  Contrast these outputs:
> ...
> The attached patches are a straight-forward copy-paste of relevant code
> from org-html-example-block.  It may be better to refactor this logic
> and ensure that it is applied on all relevant AST nodes (others are
> probably affected as well).

Sounds reasonable.
Timothy, may you have a look?
I am not sure if we want to add all the attributes to every transcoded
element. At least in some cases, we do discard them
(`org-html--textarea-block').

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-06-18 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  2:55 [PATCH] [BUG] Support attr_html in source code and fixed-width blocks Suhail Singh
2024-06-18 15:33 ` Ihor Radchenko [this message]
2024-07-19 15:28   ` Suhail Singh
2024-07-22 13:49     ` Ihor Radchenko
2024-07-22 17:11       ` Suhail Singh
2024-07-22 18:13         ` Ihor Radchenko
2024-07-22 18:45           ` Suhail Singh
2024-07-22 19:10             ` Ihor Radchenko
2024-07-22 19:35               ` Suhail Singh
2024-07-22 19:49                 ` Ihor Radchenko
2024-07-22 20:05                   ` Suhail Singh
2024-09-02 13:03                 ` Suhail Singh
2024-09-07 18:10                   ` Ihor Radchenko
2024-09-07 19:45                     ` Suhail Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cems1t4.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=orgmode@tec.tecosaur.net \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).