Re: [PATCH v9] Inline image display as part of a new org-link-preview system

[Ihor Radchenko <yantar92@posteo.net>]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> None of the above have been obsoleted.  Let me know if I should make
> them all obsolete aliases instead.

I think that an alias is fine.
At least, it is the approach I am leaning to recently.

>> Aside: I am wondering if we should also attach preview toggle to <TAB>
>> when ~org-cycle-inline-images-display~ is non-nil and there is a link at
>> point.
>
> I haven't added this.  I think it's better not to do this, since cycling
> is expected to only involve hiding/showing buffer contents.  Generating
> a preview might cause new external processes to be started.  I can add
> it if you think we should.

~org-cycle-inline-images-display~ already invokes link previews. What I
had in mind is extending it a tiny bit - I myself have this feature
locally and find it useful.

You do not have to implement it though. It is slightly out of scope of
this particular patchset.

> Subject: [PATCH 2/2] Org: Document preview API for arbitrary link types
> ...
> ...
> +  By default, only image links without a description are displayed.
> +  You can force displaying previews for all supported links using a
> +  numeric argument of ~1~ to toggle all previews in the active
> +  region, the link at point or the current section.  A numeric prefix
> +  argument of ~11~ will toggle previews in the whole buffer.

It is slightly inaccurate I think.  Once new :preview handlers are added
to non-image link types, the same rule about links with/without
description will apply to non-image links. So, we may better explain C-1
and C-11 arguments in more generic terms: "image links without
description" -> "previews for links without description"

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>