From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed. Date: Fri, 23 Oct 2015 14:59:00 -0500 Message-ID: <87611xl5kr.fsf@fastmail.fm> References: <874mhh1u7s.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpiUU-0003QB-Dt for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 15:59:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpiUR-0001i8-6M for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 15:59:06 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpiUQ-0001i3-Vz for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 15:59:03 -0400 In-Reply-To: <874mhh1u7s.fsf@gmx.us> (rasmus@gmx.us's message of "Fri, 23 Oct 2015 17:27:03 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > Hi Puneeth, > > Thanks for your patch. > > Puneeth Chaganti writes: > >> I've attached a one-line patch to fix `org-id-goto' if the target >> buffer is narrowed. Let me know if this fix sounds reasonable or if >> you have other suggestions! > > It's not obvious that org should change a=E2=80=94potentially=E2=80=94car= efully selected > narrowed region. Org mode already does this aggressively and often. For instance, it irrevocably widens all buffers associated with org-agenda-files when generating the agenda. (To replicate, try narrowing to a headline in a buffer and then calling the agenda.) The same is true of follow mode; it widens a buffer once one moves to a line in the agenda corresponding to that buffer. In other words, org currently does not go out of its way to protect user's narrowed regions. +1 on my part for widening a buffer if it contains a relevant id target. If I click org-id-goto and the target is in my buffer, I want it to widen that buffer. Matt