emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Renato Ferreira <renatofdds@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
Date: Fri, 04 Nov 2016 08:06:00 -0200	[thread overview]
Message-ID: <8760o3k19z.fsf@gmail.com> (raw)

When using:
(setq org-agenda-fontify-priorities 'cookies)
(setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
. "#AC7373") (68 . "#7C4343")))

(org-agenda-fontify-priorities) generates an (:inherit nil ...) face
alist, which ultimately (i can't trace specifically where) causes a lot
of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
when generating the agenda buffer (when it contains tasks with
priorities).

This issue has been present since 8.3 (and earlier i believe), i've
always patched locally but now i'm using melpa so it would be great if
someone could verify and merge this.

Thanks a lot,
Renato Ferreira

PATCH:
---
org-agenda.el Correct :inherit on org-agenda-fontify-priorities

* Fixes "Invalid face attribute/reference" errors

---
lisp/org-agenda.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7ee721a..68e82cb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply when
ov 'face
(let ((special-face
(cond ((org-face-from-face-or-color
-			'priority nil
+			'priority 'org-priority
(cdr (assoc p org-priority-faces))))
((and (listp org-agenda-fontify-priorities)
(org-face-from-face-or-color
-			     'priority nil
+			     'priority 'org-priority
(cdr (assoc p org-agenda-fontify-priorities)))))
((equal p l) 'italic)
((equal p h) 'bold))))
-- 

             reply	other threads:[~2016-11-04 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 10:06 Renato Ferreira [this message]
2016-11-04 12:45 ` [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities Nicolas Goaziou
2016-11-04 12:53   ` Renato Ferreira
2016-11-04 15:44     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760o3k19z.fsf@gmail.com \
    --to=renatofdds@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).