From mboxrd@z Thu Jan  1 00:00:00 1970
From: MaDhAt2r <madhat2r@dukefoo.com>
Subject: Re: [Patch v2] Add support for sqsh sql src blocks
Date: Sat, 03 Dec 2016 09:38:20 -0600
Message-ID: <8760n1xbtf.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
References: <87vavdkmes.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
	<87a8cjfe4c.fsf@nicolasgoaziou.fr>
	<87vav5zsfm.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
	<87eg1pcu5a.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <madhat2r@dukefoo.com>) id 1cDCOP-0002rR-8j
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 10:38:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <madhat2r@dukefoo.com>) id 1cDCOO-0006FZ-7c
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 10:38:25 -0500
Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:33974)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <madhat2r@dukefoo.com>)
	id 1cDCON-0006F8-VK
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 10:38:24 -0500
Received: by mail-oi0-x230.google.com with SMTP id y198so297949521oia.1
	for <emacs-orgmode@gnu.org>; Sat, 03 Dec 2016 07:38:22 -0800 (PST)
In-Reply-To: <87eg1pcu5a.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org


Thanks Nicolas.

I went ahead and set up a public branch for these changes.

I added ORG-NEWS entry, and some other minor changes in the commentary
of ob-sql.el.

https://github.com/madhat2r/org-mode/tree/feature/babel-sqsh-engine

-Micah

On Dec 03 at 09:08 AM, Nicolas Goaziou said thus:
> Hello,
>
> MaDhAt2r <madhat2r@dukefoo.com> writes:
>
>> Thanks for your comments Nicolas! I hope this is better.
>
> Thank you. This looks good.
>
> However, I'm not able to apply it on master branch. Could you rebase
> your branch against master and send that patch again?
>
> Also, could you provide an ORG-NEWS entry about the new feature?
>
>> +(defun org-babel-sql-dbstring-sqsh (host user password database)
>> +  "Make sqlcmd commmand line args for database connection.
>> +`sqsh' is one method to access Sybase or MS SQL via Linux platform"
>
> `sqsh' -> "sqsh"
>
>> +  (cond
>> +	 ((equal (intern engine) 'sqsh)
>> +    (org-table-import out-file '(4))
>> +    )
>
> The lonesome parenthesis should go to the line above it.
>
>
> Regards,
>
> -- 
> Nicolas Goaziou