From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Welle <mwe012008@gmx.net>
Subject: Re: org-entry-delete vs org-entry-put
Date: Sun, 22 Jan 2017 14:50:33 +0100
Message-ID: <8760l7fbkm.fsf@luisa.c0t0d0s0.de>
References: <87o9z03ej0.fsf@luisa.c0t0d0s0.de>
	<87d1ffb4ql.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mwe012008@gmx.net>) id 1cVIXY-0006T3-Rd
	for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:50:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mwe012008@gmx.net>) id 1cVIXV-0003oo-Lw
	for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:50:40 -0500
Received: from mout.gmx.net ([212.227.15.18]:49673)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mwe012008@gmx.net>) id 1cVIXV-0003oc-9y
	for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:50:37 -0500
Received: from stella.c0t0d0s0.de ([89.15.236.235]) by mail.gmx.com (mrgmx002
	[212.227.17.190]) with ESMTPSA (Nemesis) id 0MK17F-1cUTj40Qhp-001PqT
	for <emacs-orgmode@gnu.org>; Sun, 22 Jan 2017 14:50:35 +0100
Received: from Stella (stella.c0t0d0s0.de [192.168.42.1])
	by stella.c0t0d0s0.de (Postfix) with ESMTP id A1D3BC45FC
	for <emacs-orgmode@gnu.org>; Sun, 22 Jan 2017 14:50:33 +0100 (CET)
In-Reply-To: <87d1ffb4ql.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Sun, 22 Jan 2017 14:31:46 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hello,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Michael Welle <mwe012008@gmx.net> writes:
>
>> 1. Property names like DISABLED-SCHEDULED seem to be problematic. I
>>    guess the regexp matching the scheduled property is too greedy.
>
> What exactly is problematic? Could you expound a bit?
no, I can reproduce it today... My initial idea was to use something
like that: 

(org-entry-put pom "DISABLED-SCHEDULED" "bar")

But the created property was always named DISABLED-SCHED or DISABLED-SCHE
I can't remember exactly how the regexp matching part was meant. I tried
that a few times and every property with SCHEDULED in its name failed
that way. Sorry for the noise. 


>> 2. (org-entry-put pom "SCHEDULED" nil) removes the property, but
>>    (org-entry-delete pom "SCHEDULED")  doesn't.
>
> Fixed: `org-entry-delete' now deletes wrong "SCHEDULED" property. Thank
> you.
Thank you.


>
>>    On the other hand,   
>>    (org-entry-put pom "foo" nil) doesn't remove the property, but
>>    (org-entry-delete pom "foo")  does.
>
> I don't see any problem here given the docstring of `org-entry-put'.
No, there is no problem. I just wanted to point out, that o-e-p and
o-e-d behave different, if fed with a well known property like SCHEDULE
and a property like foo. I have no preference if (o-e-d pom "SCHEDULED")
deletes the property (like it is now) or if (o-e-p pom "foo" nil)
deletes the non well known properties. 

Regards
hmw