emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Samuel Loury <konubinix@gmail.com>
Cc: org-mode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tags-todo-only'
Date: Tue, 30 May 2017 19:00:31 +0200	[thread overview]
Message-ID: <8760gi5lg0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k29rzdyh.fsf@gmail.com> (Samuel Loury's message of "Thu, 19 Jan 2017 08:49:42 +0100")

Hello,

Samuel Loury <konubinix@gmail.com> writes:

> I would like to propose a patch for `org-tags-view' to make it stop
> setting globally `org--matcher-tags-todo-only'
>
> Setting `org--matcher-tags-todo-only' has side effects on other
> commands. For instance, the following clock table changes its behavior
> whether `org--matcher-tags-todo-only' is nil or '(4)
>
> #+BEGIN: clocktable :tags "-perso" :fileskip0 :stepskip0 :link t :maxlevel 5 :emphasize t :link t :block today-1 :scope agenda :inherit-props t
>
> I did not have time to investigate why the behavior of the clock table
> is impacted by `org--matcher-tags-todo-only'. I quickly feel lost in
> this code.
>
> From c5c763a9aca8cfd8a707b0d7e814bc37f5eeafa1 Mon Sep 17 00:00:00 2001
> From: Samuel Loury <konubinixweb@gmail.com>
> Date: Thu, 19 Jan 2017 08:39:50 +0100
> Subject: [PATCH] Make `org-tags-view' stop setting globally
>  `org--matcher-tags-todo-only'

Thank you. I eventually fixed it slightly differently.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-05-30 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  7:49 [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tags-todo-only' Samuel Loury
2017-05-30 17:00 ` Nicolas Goaziou [this message]
2017-06-13 19:28   ` agenda tags-todo (was Re: [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tags-todo-only') Christian Lynbech
2017-06-13 21:32     ` Nicolas Goaziou
2017-06-14  6:30       ` Christian Lynbech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760gi5lg0.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=konubinix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).